[objects] Extract DebugInfo and BreakPointInfo to own file

src/objects/break-points-info.h

+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_OBJECTS_BREAK_POINTS_INFO_H_
+#define V8_OBJECTS_BREAK_POINTS_INFO_H_
+
+#include "src/objects.h"
+
+// Has to be the last include (doesn't have include guards):
+#include "src/objects/object-macros.h"
+
+namespace v8 {
+namespace internal {
+
+// The BreakPointInfo class holds information for break points set in a
+// function. The DebugInfo object holds a BreakPointInfo object for each code
+// position with one or more break points.
+class BreakPointInfo : public Tuple2 {

[marja, 2017/05/22 13:37:39]

This file should be called break-point-info, since the class inside it is
BreakPointInfo.

Actually, it would also be fine to put them both into the same file, wdyt? (We
shouldn't go overboard ie too granular with objects.h splitting either.)

[jgruber, 2017/05/22 13:48:26]

Ugh, my comment got lost since I uploaded new patch-sets :) See
https://codereview.chromium.org/2900713004/diff/1/src/objects/breakpoints-inf...

+ public:
+  // The position in the source for the break position.
+  DECL_INT_ACCESSORS(source_position)
+  // List of related JavaScript break points.
+  DECL_ACCESSORS(break_point_objects, Object)
+
+  // Removes a break point.
+  static void ClearBreakPoint(Handle<BreakPointInfo> info,
+                              Handle<Object> break_point_object);
+  // Set a break point.
+  static void SetBreakPoint(Handle<BreakPointInfo> info,
+                            Handle<Object> break_point_object);
+  // Check if break point info has this break point object.
+  static bool HasBreakPointObject(Handle<BreakPointInfo> info,
+                                  Handle<Object> break_point_object);
+  // Get the number of break points for this code offset.
+  int GetBreakPointCount();
+
+  int GetStatementPosition(Handle<DebugInfo> debug_info);
+
+  DECLARE_CAST(BreakPointInfo)
+
+  static const int kSourcePositionIndex = kValue1Offset;
+  static const int kBreakPointObjectsIndex = kValue2Offset;
+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(BreakPointInfo);
+};
+
+#include "src/objects/object-macros-undef.h"

[marja, 2017/05/22 13:37:39]

This should be after the namespace closing

[jgruber, 2017/05/22 13:48:26]

Will do.

+
+}  // namespace internal
+}  // namespace v8
+
+#endif  // V8_OBJECTS_BREAK_POINTS_INFO_H_