Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2898823002: Add metrics for search engine promo and search widget (Closed)

Created:
3 years, 7 months ago by Yusuf
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for search engine promo and search widget - Adds histograms and user action for search widget use - Add histogram definitions around search engine promo use and selections - Add LocaleManager refactoring to route the signals that are important for metrics BUG=724349, 724348 Review-Url: https://codereview.chromium.org/2898823002 Cr-Commit-Position: refs/heads/master@{#474203} Committed: https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b035271723135be40829

Patch Set 1 #

Total comments: 8

Patch Set 2 : tedchoc@ comments #

Patch Set 3 : page transition annotation #

Patch Set 4 : other dependencies #

Total comments: 8

Patch Set 5 : histograms.xml updates #

Total comments: 4

Patch Set 6 : suffix affected histograms #

Patch Set 7 : prefix,2 #

Patch Set 8 : rebased #

Patch Set 9 : enums.xml formatting #

Patch Set 10 : compile for test #

Patch Set 11 : removed assert for test (expectations changed) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -10 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 2 3 4 5 6 7 8 9 10 5 chunks +58 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/locale/locale_manager.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/locale/locale_manager.cc View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M components/search_engines/BUILD.gn View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M components/search_engines/search_engine_type.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 4 5 6 7 3 chunks +32 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 4 5 6 7 8 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 47 (21 generated)
Yusuf
3 years, 7 months ago (2017-05-22 21:42:19 UTC) #2
Ted C
https://codereview.chromium.org/2898823002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java File chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java (right): https://codereview.chromium.org/2898823002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java#newcode70 chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:70: protected boolean mSearchEnginePromoShown; per offline, prefer to use hasShownSearchEnginePromo ...
3 years, 7 months ago (2017-05-22 21:57:03 UTC) #3
Yusuf
https://codereview.chromium.org/2898823002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java File chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java (right): https://codereview.chromium.org/2898823002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java#newcode70 chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:70: protected boolean mSearchEnginePromoShown; On 2017/05/22 21:57:02, Ted C wrote: ...
3 years, 7 months ago (2017-05-22 22:31:15 UTC) #4
Ted C
lgtm
3 years, 7 months ago (2017-05-22 22:56:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/40001
3 years, 7 months ago (2017-05-22 23:10:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/216416)
3 years, 7 months ago (2017-05-22 23:19:58 UTC) #10
Yusuf
tedchoc@ PTAL one last time for new dependencies I added. pkasting@ for components/search_engines and chrome/browser/search_engines/*_android ...
3 years, 7 months ago (2017-05-23 00:24:18 UTC) #12
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-23 01:07:43 UTC) #13
Ted C
still lgtm
3 years, 7 months ago (2017-05-23 14:24:44 UTC) #14
Alexei Svitkine (slow)
https://codereview.chromium.org/2898823002/diff/60001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2898823002/diff/60001/tools/metrics/actions/actions.xml#newcode14462 tools/metrics/actions/actions.xml:14462: prompting the user to pick a default search engine. ...
3 years, 7 months ago (2017-05-23 15:00:16 UTC) #15
Yusuf
https://codereview.chromium.org/2898823002/diff/60001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2898823002/diff/60001/tools/metrics/actions/actions.xml#newcode14462 tools/metrics/actions/actions.xml:14462: prompting the user to pick a default search engine. ...
3 years, 7 months ago (2017-05-23 17:40:53 UTC) #16
Alexei Svitkine (slow)
https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml#newcode92059 tools/metrics/histograms/histograms.xml:92059: + <affected-histogram name="Search.SearchEngineListedInPromoDialog"/> If you want the two suffixes ...
3 years, 7 months ago (2017-05-23 17:49:30 UTC) #17
Yusuf
https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml#newcode92059 tools/metrics/histograms/histograms.xml:92059: + <affected-histogram name="Search.SearchEngineListedInPromoDialog"/> On 2017/05/23 17:49:30, Alexei Svitkine (slow) ...
3 years, 7 months ago (2017-05-23 18:10:31 UTC) #18
Alexei Svitkine (slow)
https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml#newcode92059 tools/metrics/histograms/histograms.xml:92059: + <affected-histogram name="Search.SearchEngineListedInPromoDialog"/> On 2017/05/23 18:10:31, Yusuf wrote: > ...
3 years, 7 months ago (2017-05-23 20:03:10 UTC) #19
Yusuf
https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2898823002/diff/80001/tools/metrics/histograms/histograms.xml#newcode92059 tools/metrics/histograms/histograms.xml:92059: + <affected-histogram name="Search.SearchEngineListedInPromoDialog"/> On 2017/05/23 20:03:10, Alexei Svitkine (slow) ...
3 years, 7 months ago (2017-05-23 20:11:42 UTC) #20
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-23 20:22:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/120001
3 years, 7 months ago (2017-05-23 20:27:37 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/345722) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-23 20:32:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/140001
3 years, 7 months ago (2017-05-23 20:37:25 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445331)
3 years, 7 months ago (2017-05-23 20:51:53 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/160001
3 years, 7 months ago (2017-05-23 22:03:47 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/274479)
3 years, 7 months ago (2017-05-23 22:46:32 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/180001
3 years, 7 months ago (2017-05-23 23:03:42 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/301378)
3 years, 7 months ago (2017-05-24 04:44:41 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898823002/200001
3 years, 7 months ago (2017-05-24 04:56:59 UTC) #44
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 07:56:29 UTC) #47
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b0352717...

Powered by Google App Engine
This is Rietveld 408576698