chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java - Issue 2898823002: Add metrics for search engine promo and search widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

Issue 2898823002: Add metrics for search engine promo and search widget (Closed)

Patch Set: removed assert for test (expectations changed) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

index eeb225c73fa4b43ce7a1b0882e42ffd87a80ae4c..56bbc63078bd48247a8a8b5fb26799e2b7e7a509 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

@@ -11,6 +11,7 @@ import android.util.AttributeSet;

import android.view.View;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.locale.LocaleManager;

import org.chromium.chrome.browser.omnibox.LocationBarLayout;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.ui.UiUtils;

@@ -41,6 +42,7 @@ public class SearchActivityLocationBarLayout extends LocationBarLayout {

@Override

protected void loadUrl(String url, int transition) {

mDelegate.loadUrl(url);

+ LocaleManager.getInstance().recordLocaleBasedSearchMetrics(true, url, transition);

}

@Override