chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java - Issue 2898823002: Add metrics for search engine promo and search widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

Issue 2898823002: Add metrics for search engine promo and search widget (Closed)

Patch Set: removed assert for test (expectations changed) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

index 9678cf2948cfb7d8e343dcfb017024fa20c320ce..218ffe5b796344cdf504269edc9ad86e130a8741 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

@@ -28,6 +28,7 @@ import org.chromium.base.library_loader.LibraryLoader;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;

+import org.chromium.chrome.browser.locale.LocaleManager;

import org.chromium.chrome.browser.omnibox.LocationBarLayout;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

import org.chromium.chrome.browser.search_engines.TemplateUrlService.LoadListener;

@@ -150,6 +151,9 @@ public class SearchWidgetProvider extends AppWidgetProvider {

service.addObserver(sObserver);

if (!service.isLoaded()) service.load();

}

+ int[] ids = getDelegate().getAllSearchWidgetIds();

+ LocaleManager.getInstance().recordLocaleBasedSearchWidgetMetrics(

+ ids != null && ids.length > 0);

}

/** Nukes all cached information and forces all widgets to start with a blank slate. */