chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2898823002: Add metrics for search engine promo and search widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2898823002: Add metrics for search engine promo and search widget (Closed)

Patch Set: removed assert for test (expectations changed) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index 12c8848c7ca170597f804ab9d52277fc560f734d..95deb41d1094c9eb1234e4bc00633c1be64ebe76 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -56,6 +56,7 @@ import org.chromium.chrome.browser.ChromeSwitches;

import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.WindowDelegate;

+import org.chromium.chrome.browser.locale.LocaleManager;

import org.chromium.chrome.browser.ntp.NativePageFactory;

import org.chromium.chrome.browser.ntp.NewTabPage;

import org.chromium.chrome.browser.ntp.NewTabPage.FakeboxDelegate;

@@ -2231,6 +2232,8 @@ public class LocationBarLayout extends FrameLayout

setUrlToPageUrl();

}

+ LocaleManager.getInstance().recordLocaleBasedSearchMetrics(false, url, transition);

if (currentTab != null) currentTab.requestFocus();

// Prevent any upcoming omnibox suggestions from showing. We have to do this after we load