Closure: OK, really remove build/inputs.py this time

Closure: OK, really remove build/inputs.py this time

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898563002
Cr-Commit-Position: refs/heads/master@{#473405}
Committed: https://chromium.googlesource.com/chromium/src/+/dcee896bdaf173bfd1eb8b61e0d140150b92720c

[Dan Beam, 2017-05-20 01:25:27]

Description was changed from

==========
Closure: OK, really remove build/inputs.py this time

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
==========

to

==========
Closure: OK, really remove build/inputs.py this time

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-20 01:32:19]

lgtm

[Dan Beam, 2017-05-20 02:04:31]

found more goodies!`

[Dan Beam, 2017-05-20 02:04:37]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 02:05:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-20 02:11:56]

On 2017/05/20 at 02:04:31, dbeam wrote:
> found more goodies!`

LGTM

[dpapad, 2017-05-20 02:12:10]

https://codereview.chromium.org/2898563002/diff/20001/third_party/closure_com...
File third_party/closure_compiler/compile2.py (right):

https://codereview.chromium.org/2898563002/diff/20001/third_party/closure_com...
third_party/closure_compiler/compile2.py:191: custom_sources=False,
custom_includes=False):
Hm, so I guess currently the compilation succeeds, even when we use
"dependencies" and custom_sources=True.

[commit-bot: I haz the power, 2017-05-20 02:34:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 02:34:53]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-20 03:02:29]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:03:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-05-20 03:03:45]

https://codereview.chromium.org/2898563002/diff/20001/third_party/closure_com...
File third_party/closure_compiler/compile2.py (right):

https://codereview.chromium.org/2898563002/diff/20001/third_party/closure_com...
third_party/closure_compiler/compile2.py:191: custom_sources=False,
custom_includes=False):
On 2017/05/20 02:12:10, dpapad wrote:
> Hm, so I guess currently the compilation succeeds, even when we use
> "dependencies" and custom_sources=True.

this is always specified from the |opts| below

https://codereview.chromium.org/2898563002/diff/20001/third_party/closure_com...
third_party/closure_compiler/compile2.py:334:
custom_sources=opts.custom_sources,
these are always false unless a flag is present

[commit-bot: I haz the power, 2017-05-20 03:12:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495249349035700,
"parent_rev": "7e366be1231e6817013a9579805e021358fe99b7", "commit_rev":
"dcee896bdaf173bfd1eb8b61e0d140150b92720c"}

[commit-bot: I haz the power, 2017-05-20 03:12:31]

Description was changed from

==========
Closure: OK, really remove build/inputs.py this time

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Closure: OK, really remove build/inputs.py this time

Last time there was a spurious import that broke the build.  So I
quickly restored the build to open the tree (broke Android compile).
This time, Im fairly sure nothing is using inputs.py.  Lets try again.

Unfortunately, the CQ doesnt seem to catch these types of errors or has
some stale .pyc files lying around or something. Unlucky.

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898563002
Cr-Commit-Position: refs/heads/master@{#473405}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcee896bdaf173bfd1eb8b61e0d1...
==========

[commit-bot: I haz the power, 2017-05-20 03:12:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dcee896bdaf173bfd1eb8b61e0d1...