Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2900473002: Closure: add back third_party/closure_compiler/build/inputs.py (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: add back third_party/closure_compiler/build/inputs.py Some stale .pyc files allowed its removal to go unnoticed on bots and locally for me, it looks like. This is a partial revert of r473381. TBR=thestig@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2900473002 . Cr-Commit-Position: refs/heads/master@{#473383} Committed: https://chromium.googlesource.com/chromium/src/+/5d7242684703b56b5760c77268fee1c313796358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
A third_party/closure_compiler/build/inputs.py View 1 chunk +101 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
Dan Beam
3 years, 7 months ago (2017-05-19 23:35:40 UTC) #2
Dan Beam
Committed patchset #1 (id:1) manually as 5d7242684703b56b5760c77268fee1c313796358 (tree was closed).
3 years, 7 months ago (2017-05-19 23:36:40 UTC) #4
Lei Zhang
3 years, 7 months ago (2017-05-19 23:44:37 UTC) #6
Message was sent while issue was closed.
Actually, fukino@ reviewed this in https://codereview.chromium.org/2887253006 so
I politely decline.

Powered by Google App Engine
This is Rietveld 408576698