Closure: OK, really remove build/inputs.py this time

third_party/closure_compiler/compile2.py

 #!/usr/bin/python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on JavaScript files to check for errors and produce
 minified output."""
 
 import argparse
 import os
 import re
 import subprocess
 import sys
 import tempfile
 
-import build.inputs
 import processor
 import error_filter
 
 
 _CURRENT_DIR = os.path.join(os.path.dirname(__file__))
 
 
 class Checker(object):
   """Runs the Closure compiler on given source files to typecheck them
   and produce minified output."""
@@ skipping 155 matching lines @@
 
     Return:
       The filepath of the newly created, written, and closed temporary file.
     """
     with tempfile.NamedTemporaryFile(mode="wt", delete=False) as tmp_file:
       self._temp_files.append(tmp_file.name)
       tmp_file.write(contents)
     return tmp_file.name
 
   def check(self, sources, out_file, closure_args=None,
-            custom_sources=True, custom_includes=False):
+            custom_sources=False, custom_includes=False):

[dpapad, 2017/05/20 02:12:10]

Hm, so I guess currently the compilation succeeds, even when we use
"dependencies" and custom_sources=True.

[Dan Beam, 2017/05/20 03:03:45]

this is always specified from the |opts| below

     """Closure compile |sources| while checking for errors.
 
     Args:
       sources: Files to check. sources[0] is the typically the target file.
           sources[1:] are externs and dependencies in topological order. Order
           is not guaranteed if custom_sources is True.
       out_file: A file where the compiled output is written to.
       closure_args: Arguments passed directly to the Closure compiler.
       custom_sources: Whether |sources| was customized by the target (e.g. not
           in GYP dependency order).
@@ skipping 122 matching lines @@
   parser.add_argument("-c", "--closure_args", nargs=argparse.ZERO_OR_MORE,
                       help="Arguments passed directly to the Closure compiler")
   parser.add_argument("-v", "--verbose", action="store_true",
                       help="Show more information as this script runs")
   opts = parser.parse_args()
 
   checker = Checker(verbose=opts.verbose)
 
   found_errors, stderr = checker.check(opts.sources, out_file=opts.out_file,
                                        closure_args=opts.closure_args,
                                        custom_sources=opts.custom_sources,

[Dan Beam, 2017/05/20 03:03:45]

these are always false unless a flag is present

                                        custom_includes=opts.custom_includes)
 
   if found_errors:
     if opts.custom_sources:
       print stderr
     sys.exit(1)