third_party/closure_compiler/compile2.py - Issue 2898563002: Closure: OK, really remove build/inputs.py this time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2898563002: Closure: OK, really remove build/inputs.py this time (Closed)

Patch Set: update run_tests.py Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/compile2.py

diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py

index 787b76ed2cbb710937016b3bb9f0934b8a9c18f0..a292c8dd732b2a4c76054e39b9a3d17d85ffebf0 100755

--- a/third_party/closure_compiler/compile2.py

+++ b/third_party/closure_compiler/compile2.py

@@ -13,7 +13,6 @@ import subprocess

import sys

import tempfile

-import build.inputs

import processor

import error_filter

@@ -189,7 +188,7 @@ class Checker(object):

return tmp_file.name

def check(self, sources, out_file, closure_args=None,

- custom_sources=True, custom_includes=False):

+ custom_sources=False, custom_includes=False):

dpapad 2017/05/20 02:12:10 Hm, so I guess currently the compilation succeeds,

Dan Beam 2017/05/20 03:03:45 this is always specified from the |opts| below

"""Closure compile |sources| while checking for errors.

Args: