Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2898433002: Revert of Move //device/generic_sensor to be part of the internal implementation of the Device Service. (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, shalamov, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, haraken, jam, mac-reviews_chromium.org, Mikhail, mlamouri+watch-sensors_chromium.org, qsr+mojo_chromium.org, riju_, timvolodine, viettrungluu+watch_chromium.org, wanming.lin, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move //device/generic_sensor to be part of the internal implementation of the Device Service. (patchset #11 id:200001 of https://codereview.chromium.org/2865263002/ ) Reason for revert: Seems to have broken GenericSensorBrowserTest.AmbientLightSensorTest: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/60103 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/40665 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26223 Original issue's description: > Remove the *.export.h, change the gn target 'component' to 'source_set', which makes the generic sensor to be the internal implementation of //services. > > BUG=689384 > > Review-Url: https://codereview.chromium.org/2865263002 > Cr-Commit-Position: refs/heads/master@{#473160} > Committed: https://chromium.googlesource.com/chromium/src/+/9b5cf7f93a4b2f246d08208ccd17804856c38f6a TBR=rockot@chromium.org,blundell@chromium.org,jam@chromium.org,alexander.shalamov@intel.com,tsepez@chromium.org,reillyg@chromium.org,ke.he@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689384 Review-Url: https://codereview.chromium.org/2898433002 Cr-Commit-Position: refs/heads/master@{#473172} Committed: https://chromium.googlesource.com/chromium/src/+/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6956 lines, -6867 lines) Patch
M content/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/generic_sensor_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M device/BUILD.gn View 4 chunks +15 lines, -0 lines 0 comments Download
A device/generic_sensor/BUILD.gn View 1 chunk +138 lines, -0 lines 0 comments Download
A device/generic_sensor/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A device/generic_sensor/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A device/generic_sensor/README.md View 1 chunk +71 lines, -0 lines 0 comments Download
A device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java View 1 chunk +245 lines, -0 lines 0 comments Download
A device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java View 1 chunk +167 lines, -0 lines 0 comments Download
A device/generic_sensor/android/sensors_jni_registrar.h View 1 chunk +24 lines, -0 lines 0 comments Download
A device/generic_sensor/android/sensors_jni_registrar.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A device/generic_sensor/fake_platform_sensor.h View 1 chunk +46 lines, -0 lines 0 comments Download
A device/generic_sensor/fake_platform_sensor.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A device/generic_sensor/fake_platform_sensor_provider.h View 1 chunk +31 lines, -0 lines 0 comments Download
A device/generic_sensor/fake_platform_sensor_provider.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A device/generic_sensor/generic_sensor_consts.h View 1 chunk +39 lines, -0 lines 0 comments Download
A device/generic_sensor/generic_sensor_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A device/generic_sensor/linux/sensor_data_linux.h View 1 chunk +82 lines, -0 lines 0 comments Download
A device/generic_sensor/linux/sensor_data_linux.cc View 1 chunk +212 lines, -0 lines 0 comments Download
A device/generic_sensor/linux/sensor_device_manager.h View 1 chunk +86 lines, -0 lines 0 comments Download
A device/generic_sensor/linux/sensor_device_manager.cc View 1 chunk +173 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor.h View 1 chunk +111 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_accelerometer_mac.h View 1 chunk +55 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_accelerometer_mac.cc View 1 chunk +103 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_ambient_light_mac.h View 1 chunk +63 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_ambient_light_mac.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 chunk +656 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 1 chunk +723 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_android.h View 1 chunk +55 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_android.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_linux.h View 1 chunk +66 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_linux.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider.h View 1 chunk +37 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_android.h View 1 chunk +35 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_android.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_base.h View 1 chunk +84 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_base.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_linux.h View 1 chunk +122 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_linux.cc View 1 chunk +214 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_mac.h View 1 chunk +30 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_mac.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_unittest.cc View 1 chunk +410 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_win.h View 1 chunk +73 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_provider_win.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_reader_linux.h View 1 chunk +73 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_reader_linux.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_reader_win.h View 1 chunk +82 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_reader_win.cc View 1 chunk +472 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_win.h View 1 chunk +62 lines, -0 lines 0 comments Download
A device/generic_sensor/platform_sensor_win.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/generic_sensor_public_export.h View 1 chunk +30 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/platform_sensor_configuration.h View 1 chunk +35 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/platform_sensor_configuration.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/sensor_reading.h View 1 chunk +116 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/sensor_reading.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/sensor_struct_traits.h View 1 chunk +26 lines, -0 lines 0 comments Download
A device/generic_sensor/public/cpp/sensor_struct_traits.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/sensor.mojom View 1 chunk +91 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/sensor.typemap View 1 chunk +13 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/sensor_provider.mojom View 1 chunk +51 lines, -0 lines 0 comments Download
A device/generic_sensor/public/interfaces/typemaps.gni View 1 chunk +5 lines, -0 lines 0 comments Download
A device/generic_sensor/sensor_impl.h View 1 chunk +50 lines, -0 lines 0 comments Download
A device/generic_sensor/sensor_impl.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A device/generic_sensor/sensor_provider_impl.h View 1 chunk +53 lines, -0 lines 0 comments Download
A device/generic_sensor/sensor_provider_impl.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 2 chunks +1 line, -1 line 0 comments Download
M services/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/device/BUILD.gn View 5 chunks +1 line, -21 lines 0 comments Download
M services/device/android/register_jni.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M services/device/device_service.h View 2 chunks +1 line, -1 line 0 comments Download
M services/device/device_service.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/device/generic_sensor/BUILD.gn View 1 chunk +0 lines, -135 lines 0 comments Download
D services/device/generic_sensor/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D services/device/generic_sensor/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D services/device/generic_sensor/README.md View 1 chunk +0 lines, -71 lines 0 comments Download
D services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java View 1 chunk +0 lines, -245 lines 0 comments Download
D services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java View 1 chunk +0 lines, -167 lines 0 comments Download
D services/device/generic_sensor/android/sensors_jni_registrar.h View 1 chunk +0 lines, -22 lines 0 comments Download
D services/device/generic_sensor/android/sensors_jni_registrar.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D services/device/generic_sensor/fake_platform_sensor.h View 1 chunk +0 lines, -46 lines 0 comments Download
D services/device/generic_sensor/fake_platform_sensor.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D services/device/generic_sensor/fake_platform_sensor_provider.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/device/generic_sensor/fake_platform_sensor_provider.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D services/device/generic_sensor/generic_sensor_consts.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/device/generic_sensor/linux/sensor_data_linux.h View 1 chunk +0 lines, -80 lines 0 comments Download
D services/device/generic_sensor/linux/sensor_data_linux.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D services/device/generic_sensor/linux/sensor_device_manager.h View 1 chunk +0 lines, -84 lines 0 comments Download
D services/device/generic_sensor/linux/sensor_device_manager.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D services/device/generic_sensor/platform_sensor.h View 1 chunk +0 lines, -109 lines 0 comments Download
D services/device/generic_sensor/platform_sensor.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_accelerometer_mac.h View 1 chunk +0 lines, -55 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_accelerometer_mac.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_ambient_light_mac.h View 1 chunk +0 lines, -63 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_ambient_light_mac.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 chunk +0 lines, -656 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 1 chunk +0 lines, -723 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_android.h View 1 chunk +0 lines, -55 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_android.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_linux.h View 1 chunk +0 lines, -66 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_linux.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider.h View 1 chunk +0 lines, -35 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_android.h View 1 chunk +0 lines, -35 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_android.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_base.h View 1 chunk +0 lines, -83 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_base.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_linux.h View 1 chunk +0 lines, -120 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_linux.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_mac.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_mac.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_unittest.cc View 1 chunk +0 lines, -410 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_win.h View 1 chunk +0 lines, -71 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_provider_win.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_reader_linux.h View 1 chunk +0 lines, -72 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_reader_linux.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_reader_win.h View 1 chunk +0 lines, -82 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_reader_win.cc View 1 chunk +0 lines, -472 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_win.h View 1 chunk +0 lines, -62 lines 0 comments Download
D services/device/generic_sensor/platform_sensor_win.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D services/device/generic_sensor/sensor_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D services/device/generic_sensor/sensor_impl.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D services/device/generic_sensor/sensor_provider_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D services/device/generic_sensor/sensor_provider_impl.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D services/device/public/cpp/generic_sensor/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D services/device/public/cpp/generic_sensor/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/device/public/cpp/generic_sensor/platform_sensor_configuration.h View 1 chunk +0 lines, -34 lines 0 comments Download
D services/device/public/cpp/generic_sensor/platform_sensor_configuration.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D services/device/public/cpp/generic_sensor/sensor_reading.h View 1 chunk +0 lines, -115 lines 0 comments Download
D services/device/public/cpp/generic_sensor/sensor_reading.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D services/device/public/cpp/generic_sensor/sensor_struct_traits.h View 1 chunk +0 lines, -26 lines 0 comments Download
D services/device/public/cpp/generic_sensor/sensor_struct_traits.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M services/device/public/interfaces/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M services/device/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D services/device/public/interfaces/sensor.mojom View 1 chunk +0 lines, -91 lines 0 comments Download
D services/device/public/interfaces/sensor.typemap View 1 chunk +0 lines, -13 lines 0 comments Download
D services/device/public/interfaces/sensor_provider.mojom View 1 chunk +0 lines, -51 lines 0 comments Download
D services/device/public/interfaces/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/DEPS View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Marc Treib
3 years, 7 months ago (2017-05-19 13:07:30 UTC) #2
Created Revert of Move //device/generic_sensor to be part of the internal
implementation of the Device Service.

Powered by Google App Engine
This is Rietveld 408576698