[Extensions] Remove "show button" UI from chrome://extensions

[Extensions] Remove "show button" UI from chrome://extensions

The chrome://extensions page used to have a "show button" UI for
displaying a hidden extension action. Since the extension action
redesign feature launched (over a year ago), this is no longer
necessary. Remove it and update the developerPrivate API appropriately.

BUG=590321
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898203004
Cr-Commit-Position: refs/heads/master@{#475975}
Committed: https://chromium.googlesource.com/chromium/src/+/c035e2fbc8af98800c00539ad06f7e9b7b9ec9ed

[Devlin, 2017-05-24 16:38:43]

Description was changed from

==========
[Extensions] Remove "show button" UI from chrome://extensions

The chrome://extensions page used to have a "show button" UI for
displaying a hidden extension action. Since the extension action
redesign feature launched (over a year ago), this is no longer
necessary. Remove it and update the developerPrivate API appropriately.

BUG=590321
==========

to

==========
[Extensions] Remove "show button" UI from chrome://extensions

The chrome://extensions page used to have a "show button" UI for
displaying a hidden extension action. Since the extension action
redesign feature launched (over a year ago), this is no longer
necessary. Remove it and update the developerPrivate API appropriately.

BUG=590321
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-05-24 16:39:04]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:39:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:08:09]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-24 18:40:39]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org, karandeepb@chromium.org

[Devlin, 2017-05-24 18:40:39]

Heya folks, mind taking a look?  Pretty simple cleanup.
dbeam@: c/b/resources, c/b/ui/webui, third_party/closure_compiler
karandeepb@: c/b/extensions, c/c/extensions

Cheers!

[karandeepb, 2017-05-24 21:02:22]

LGTM.

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/extension_info_generator.cc
(left):

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/extension_info_generator.cc:317:
!extension_action_api_->GetBrowserActionVisibility(extension.id()) &&
I think the Get/SetBrowserActionVisibility and associated code can also be
removed. I am assuming you plan to do it subsequently for this bug.

[Devlin, 2017-05-26 21:06:33]

Dan, friendly ping?

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/extension_info_generator.cc
(left):

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/extension_info_generator.cc:317:
!extension_action_api_->GetBrowserActionVisibility(extension.id()) &&
On 2017/05/24 21:02:22, karandeepb wrote:
> I think the Get/SetBrowserActionVisibility and associated code can also be
> removed. I am assuming you plan to do it subsequently for this bug.

Correct. :)

[Dan Beam, 2017-05-30 23:31:43]

lgtm

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:25:
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
still used?

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:246:
extension_action_api_observer_(this),
and this

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:258:
extension_action_api_observer_.Add(ExtensionActionAPI::Get(profile));
and this

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:374:
void DeveloperPrivateEventRouter::OnExtensionActionVisibilityChanged(
and this

[Devlin, 2017-05-31 15:42:33]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 15:43:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 17:16:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:16:31]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-31 18:04:53]

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:25:
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
On 2017/05/30 23:31:43, Dan Beam wrote:
> still used?

Good catch, removed.

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:246:
extension_action_api_observer_(this),
On 2017/05/30 23:31:43, Dan Beam wrote:
> and this

Done.

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:258:
extension_action_api_observer_.Add(ExtensionActionAPI::Get(profile));
On 2017/05/30 23:31:43, Dan Beam wrote:
> and this

Done.

https://codereview.chromium.org/2898203004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:374:
void DeveloperPrivateEventRouter::OnExtensionActionVisibilityChanged(
On 2017/05/30 23:31:43, Dan Beam wrote:
> and this

Done.

[Devlin, 2017-05-31 18:05:01]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-05-31 18:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
karandeepb@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2898203004/#ps20001
(title: "Dan's")

[commit-bot: I haz the power, 2017-05-31 18:05:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:11:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496253901021360,
"parent_rev": "e628751a76d44af005f29a43445d686ebe1757e1", "commit_rev":
"c035e2fbc8af98800c00539ad06f7e9b7b9ec9ed"}

[commit-bot: I haz the power, 2017-05-31 19:11:24]

Description was changed from

==========
[Extensions] Remove "show button" UI from chrome://extensions

The chrome://extensions page used to have a "show button" UI for
displaying a hidden extension action. Since the extension action
redesign feature launched (over a year ago), this is no longer
necessary. Remove it and update the developerPrivate API appropriately.

BUG=590321
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Extensions] Remove "show button" UI from chrome://extensions

The chrome://extensions page used to have a "show button" UI for
displaying a hidden extension action. Since the extension action
redesign feature launched (over a year ago), this is no longer
necessary. Remove it and update the developerPrivate API appropriately.

BUG=590321
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2898203004
Cr-Commit-Position: refs/heads/master@{#475975}
Committed:
https://chromium.googlesource.com/chromium/src/+/c035e2fbc8af98800c00539ad06f...
==========

[commit-bot: I haz the power, 2017-05-31 19:11:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c035e2fbc8af98800c00539ad06f...