[Extensions] Remove "show button" UI from chrome://extensions

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/guid.h"
 #include "base/lazy_instance.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_scheduler/post_task.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/api/developer_private/developer_private_mangle.h"
 #include "chrome/browser/extensions/api/developer_private/entry_picker.h"
 #include "chrome/browser/extensions/api/developer_private/extension_info_generator.h"
 #include "chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

[Dan Beam, 2017/05/30 23:31:43]

still used?

[Devlin, 2017/05/31 18:04:53]

Good catch, removed.

 #include "chrome/browser/extensions/devtools_util.h"
 #include "chrome/browser/extensions/extension_commands_global_registry.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/extension_ui_util.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/install_verifier.h"
 #include "chrome/browser/extensions/path_util.h"
 #include "chrome/browser/extensions/scripting_permissions_modifier.h"
 #include "chrome/browser/extensions/shared_module_service.h"
@@ skipping 200 matching lines @@
 DeveloperPrivateAPI::DeveloperPrivateAPI(content::BrowserContext* context)
     : profile_(Profile::FromBrowserContext(context)), weak_factory_(this) {
   RegisterNotifications();
 }
 
 DeveloperPrivateEventRouter::DeveloperPrivateEventRouter(Profile* profile)
     : extension_registry_observer_(this),
       error_console_observer_(this),
       process_manager_observer_(this),
       app_window_registry_observer_(this),
       extension_action_api_observer_(this),

[Dan Beam, 2017/05/30 23:31:43]

and this

[Devlin, 2017/05/31 18:04:53]

Done.

       warning_service_observer_(this),
       extension_prefs_observer_(this),
       extension_management_observer_(this),
       command_service_observer_(this),
       profile_(profile),
       event_router_(EventRouter::Get(profile_)),
       weak_factory_(this) {
   extension_registry_observer_.Add(ExtensionRegistry::Get(profile_));
   error_console_observer_.Add(ErrorConsole::Get(profile));
   process_manager_observer_.Add(ProcessManager::Get(profile));
   app_window_registry_observer_.Add(AppWindowRegistry::Get(profile));
   extension_action_api_observer_.Add(ExtensionActionAPI::Get(profile));

[Dan Beam, 2017/05/30 23:31:43]

and this

[Devlin, 2017/05/31 18:04:53]

Done.

   warning_service_observer_.Add(WarningService::Get(profile));
   extension_prefs_observer_.Add(ExtensionPrefs::Get(profile));
   extension_management_observer_.Add(
       ExtensionManagementFactory::GetForBrowserContext(profile));
   command_service_observer_.Add(CommandService::Get(profile));
   pref_change_registrar_.Init(profile->GetPrefs());
   // The unretained is safe, since the PrefChangeRegistrar unregisters the
   // callback on destruction.
   pref_change_registrar_.Add(
       prefs::kExtensionsUIDeveloperMode,
@@ skipping 95 matching lines @@
                             extension_id);
 }
 
 void DeveloperPrivateEventRouter::OnExtensionCommandRemoved(
     const std::string& extension_id,
     const Command& removed_command) {
   BroadcastItemStateChanged(developer::EVENT_TYPE_PREFS_CHANGED,
                             extension_id);
 }
 
 void DeveloperPrivateEventRouter::OnExtensionActionVisibilityChanged(

[Dan Beam, 2017/05/30 23:31:43]

and this

[Devlin, 2017/05/31 18:04:53]

Done.

     const std::string& extension_id,
     bool is_now_visible) {
   BroadcastItemStateChanged(developer::EVENT_TYPE_PREFS_CHANGED, extension_id);
 }
 
 void DeveloperPrivateEventRouter::OnExtensionDisableReasonsChanged(
     const std::string& extension_id, int disable_reasons) {
   BroadcastItemStateChanged(developer::EVENT_TYPE_PREFS_CHANGED, extension_id);
 }
 
@@ skipping 329 matching lines @@
   if (update.run_on_all_urls) {
     ScriptingPermissionsModifier modifier(browser_context(), extension);
     if (!modifier.CanAffectExtension(
             extension->permissions_data()->active_permissions()) &&
         !modifier.HasAffectedExtension()) {
       return RespondNow(
           Error("Cannot modify all urls of extension: " + extension->id()));
     }
     modifier.SetAllowedOnAllUrls(*update.run_on_all_urls);
   }
-  if (update.show_action_button) {
-    ExtensionActionAPI::Get(browser_context())->SetBrowserActionVisibility(
-        extension->id(),
-        *update.show_action_button);
-  }
 
   return RespondNow(NoArguments());
 }
 
 DeveloperPrivateReloadFunction::~DeveloperPrivateReloadFunction() {}
 
 ExtensionFunction::ResponseAction DeveloperPrivateReloadFunction::Run() {
   std::unique_ptr<Reload::Params> params(Reload::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
@@ skipping 837 matching lines @@
         update.extension_id, update.command_name, *update.keybinding);
   }
 
   return RespondNow(NoArguments());
 }
 
 
 }  // namespace api
 
 }  // namespace extensions