chrome/browser/extensions/api/developer_private/extension_info_generator.cc - Issue 2898203004: [Extensions] Remove "show button" UI from chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 2898203004: [Extensions] Remove "show button" UI from chrome://extensions (Closed)

Patch Set: Dan's Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/resources/extensions/extension_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

index a9f4ffc6de9746b9b0b4946a5c2e2117d743acef..e0dcc70f24d6b296d5302dc71e297578e49e0dea 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -311,12 +311,6 @@ void ExtensionInfoGenerator::CreateExtensionInfoHelper(

std::unique_ptr<developer::ExtensionInfo> info(

new developer::ExtensionInfo());

- // Don't consider the button hidden with the redesign, because "hidden"

- // buttons are now just hidden in the wrench menu.

- info->action_button_hidden =

- !extension_action_api_->GetBrowserActionVisibility(extension.id()) &&

- !FeatureSwitch::extension_action_redesign()->IsEnabled();

// Blacklist text.

int blacklist_text = -1;

switch (extension_prefs_->GetExtensionBlacklistState(extension.id())) {