[Extensions] Remove "show button" UI from chrome://extensions

chrome/browser/extensions/api/developer_private/extension_info_generator.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/extension_info_generator.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 293 matching lines @@
     callback_ = callback;
   }
 }
 
 void ExtensionInfoGenerator::CreateExtensionInfoHelper(
     const Extension& extension,
     developer::ExtensionState state) {
   std::unique_ptr<developer::ExtensionInfo> info(
       new developer::ExtensionInfo());
 
-  // Don't consider the button hidden with the redesign, because "hidden"
-  // buttons are now just hidden in the wrench menu.
-  info->action_button_hidden =
-      !extension_action_api_->GetBrowserActionVisibility(extension.id()) &&

[karandeepb, 2017/05/24 21:02:22]

I think the Get/SetBrowserActionVisibility and associated code can also be
removed. I am assuming you plan to do it subsequently for this bug.

[Devlin, 2017/05/26 21:06:32]

Correct. :)

-      !FeatureSwitch::extension_action_redesign()->IsEnabled();
-
   // Blacklist text.
   int blacklist_text = -1;
   switch (extension_prefs_->GetExtensionBlacklistState(extension.id())) {
     case BLACKLISTED_MALWARE:
       blacklist_text = IDS_OPTIONS_BLACKLISTED_MALWARE;
       break;
     case BLACKLISTED_SECURITY_VULNERABILITY:
       blacklist_text = IDS_OPTIONS_BLACKLISTED_SECURITY_VULNERABILITY;
       break;
     case BLACKLISTED_CWS_POLICY_VIOLATION:
@@ skipping 308 matching lines @@
 
   if (pending_image_loads_ == 0) {  // All done!
     ExtensionInfoList list = std::move(list_);
     list_.clear();
     base::ResetAndReturn(&callback_).Run(std::move(list));
     // WARNING: |this| is possibly deleted after this line!
   }
 }
 
 }  // namespace extensions