Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2897883002: Make RubyPosition an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RubyPosition an enum class. This patch makes RubyPosition an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2897883002 Cr-Commit-Position: refs/heads/master@{#474923} Committed: https://chromium.googlesource.com/chromium/src/+/ec8d10454b0e3672746db92a5d2dee67f5e336dc

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementTest.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-25 23:27:41 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-26 05:12:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897883002/40001
3 years, 7 months ago (2017-05-26 05:22:38 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 05:27:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec8d10454b0e3672746db92a5d2d...

Powered by Google App Engine
This is Rietveld 408576698