Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2897883002: Make RubyPosition an enum class. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 6c07e882094a867bbe045319a66bc9cf7dfbe742..6187bd05ea7a498613426e64652c380c31c643f6 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1580,10 +1580,10 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(RubyPosition position)
: CSSValue(kIdentifierClass) {
switch (position) {
- case kRubyPositionBefore:
+ case RubyPosition::kBefore:
value_id_ = CSSValueBefore;
break;
- case kRubyPositionAfter:
+ case RubyPosition::kAfter:
value_id_ = CSSValueAfter;
break;
}
@@ -1593,15 +1593,15 @@ template <>
inline RubyPosition CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueBefore:
- return kRubyPositionBefore;
+ return RubyPosition::kBefore;
case CSSValueAfter:
- return kRubyPositionAfter;
+ return RubyPosition::kAfter;
default:
break;
}
NOTREACHED();
- return kRubyPositionBefore;
+ return RubyPosition::kBefore;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698