Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2897883002: Make RubyPosition an enum class. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 1562 matching lines...) Expand 10 before | Expand all | Expand 10 after
1573 } 1573 }
1574 1574
1575 NOTREACHED(); 1575 NOTREACHED();
1576 return kTextCombineNone; 1576 return kTextCombineNone;
1577 } 1577 }
1578 1578
1579 template <> 1579 template <>
1580 inline CSSIdentifierValue::CSSIdentifierValue(RubyPosition position) 1580 inline CSSIdentifierValue::CSSIdentifierValue(RubyPosition position)
1581 : CSSValue(kIdentifierClass) { 1581 : CSSValue(kIdentifierClass) {
1582 switch (position) { 1582 switch (position) {
1583 case kRubyPositionBefore: 1583 case RubyPosition::kBefore:
1584 value_id_ = CSSValueBefore; 1584 value_id_ = CSSValueBefore;
1585 break; 1585 break;
1586 case kRubyPositionAfter: 1586 case RubyPosition::kAfter:
1587 value_id_ = CSSValueAfter; 1587 value_id_ = CSSValueAfter;
1588 break; 1588 break;
1589 } 1589 }
1590 } 1590 }
1591 1591
1592 template <> 1592 template <>
1593 inline RubyPosition CSSIdentifierValue::ConvertTo() const { 1593 inline RubyPosition CSSIdentifierValue::ConvertTo() const {
1594 switch (value_id_) { 1594 switch (value_id_) {
1595 case CSSValueBefore: 1595 case CSSValueBefore:
1596 return kRubyPositionBefore; 1596 return RubyPosition::kBefore;
1597 case CSSValueAfter: 1597 case CSSValueAfter:
1598 return kRubyPositionAfter; 1598 return RubyPosition::kAfter;
1599 default: 1599 default:
1600 break; 1600 break;
1601 } 1601 }
1602 1602
1603 NOTREACHED(); 1603 NOTREACHED();
1604 return kRubyPositionBefore; 1604 return RubyPosition::kBefore;
1605 } 1605 }
1606 1606
1607 template <> 1607 template <>
1608 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisPosition position) 1608 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisPosition position)
1609 : CSSValue(kIdentifierClass) { 1609 : CSSValue(kIdentifierClass) {
1610 switch (position) { 1610 switch (position) {
1611 case kTextEmphasisPositionOver: 1611 case kTextEmphasisPositionOver:
1612 value_id_ = CSSValueOver; 1612 value_id_ = CSSValueOver;
1613 break; 1613 break;
1614 case kTextEmphasisPositionUnder: 1614 case kTextEmphasisPositionUnder:
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
3320 default: 3320 default:
3321 break; 3321 break;
3322 } 3322 }
3323 NOTREACHED(); 3323 NOTREACHED();
3324 return kContainsNone; 3324 return kContainsNone;
3325 } 3325 }
3326 3326
3327 } // namespace blink 3327 } // namespace blink
3328 3328
3329 #endif 3329 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698