third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp - Issue 2897883002: Make RubyPosition an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

Issue 2897883002: Make RubyPosition an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

index 1c7245d4641e991245342dfe6bf1669f5c2486cd..1cfd6c55b4b8c77cd54c0af129d29606de66e89b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp

@@ -236,7 +236,7 @@ void LayoutRubyRun::UpdateLayout() {

}

if (Style()->IsFlippedLinesWritingMode() ==

- (Style()->GetRubyPosition() == kRubyPositionAfter)) {

+ (Style()->GetRubyPosition() == RubyPosition::kAfter)) {

LayoutUnit first_line_top;

if (LayoutRubyBase* rb = RubyBase()) {

RootInlineBox* root_box = rb->FirstRootBox();