Generate diffs for all fields on StyleRareInheritedData

Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions
Review-Url: https://codereview.chromium.org/2897193005
Cr-Commit-Position: refs/heads/master@{#474959}
Committed: https://chromium.googlesource.com/chromium/src/+/3f6091b333bf47b3cb8650f11fe41aced37568a3

[nainar, 2017-05-25 07:40:23]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-05-25 07:40:34]

Description was changed from

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

BUG=710938
==========

to

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: Diff: https://gist.github.com/1a1e05094e979dca36918e852b2b8ac3/revisions

BUG=710938
==========

[commit-bot: I haz the power, 2017-05-25 07:40:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-25 07:44:44]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-25 07:44:44]

shend@, 

PTAL? 

Thanks!

[shend, 2017-05-25 08:20:20]

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:934: } else {
Where did this come from?

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:553: StyleColor
TextEmphasisColor() const {
Why are these moved?

[nainar, 2017-05-25 08:37:33]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 08:37:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-25 08:38:50]

shend@, 

Responded to comments. PTAL? 

Thanks@

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:934: } else {
On 2017/05/25 at 08:20:19, shend wrote:
> Where did this come from?

Aaaah landed two patches and the diff changed. Uploaded a new one.

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:553: StyleColor
TextEmphasisColor() const {
On 2017/05/25 at 08:20:19, shend wrote:
> Why are these moved?

They were private before and need to be public to diff

[commit-bot: I haz the power, 2017-05-25 11:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 11:45:11]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-25 22:19:53]

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2897193005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:553: StyleColor
TextEmphasisColor() const {
On 2017/05/25 at 08:38:50, nainar wrote:
> On 2017/05/25 at 08:20:19, shend wrote:
> > Why are these moved?
> 
> They were private before and need to be public to diff

Hmm, these were private a for a reason (never access colors directly). I would
try to keep them as private. I think it'll still work if they're private.
Otherwise, we can just make it a friend.

[nainar, 2017-05-26 00:53:08]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[nainar, 2017-05-26 00:53:24]

Description was changed from

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: Diff: https://gist.github.com/1a1e05094e979dca36918e852b2b8ac3/revisions

BUG=710938
==========

to

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions
BUG=710938
==========

[nainar, 2017-05-26 00:53:58]

shend@, 

Made the changes you asked for, PTAL? Thanks

[commit-bot: I haz the power, 2017-05-26 00:54:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-26 01:04:40]

lgtm

[nainar, 2017-05-26 01:09:38]

nainar@chromium.org changed reviewers:
+ meade@chromium.org

[nainar, 2017-05-26 01:09:39]

meade@, 

PTAL? Thanks!

[commit-bot: I haz the power, 2017-05-26 03:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 03:45:43]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-05-26 05:13:27]

lgtm

https://codereview.chromium.org/2897193005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
(right):

https://codereview.chromium.org/2897193005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5:48:
"padding-bottom", "-webkit-highlight", "text-indent", "text-align-last",
"TextIndentLine", "EffectiveZoom", "word-break", "overflow-wrap",
"-webkit-line-break", "-webkit-text-security", "hyphens",
"HyphenationLimitBefore", "HyphenationLimitAfter",
"-webkit-hyphenate-character", "RespectImageOrientation",
"-webkit-ruby-position", "TextEmphasisMark", "TextEmphasisPosition",
"TextEmphasisCustomMark", "text-justify", "text-orientation",
"text-combine-upright", "tab-size", "text-size-adjust", "list-style-image",
"line-height-step", "-webkit-text-stroke-width", "line-height", "font",
"-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing",
"TextAutosizingMultiplier"],
This line is getting pretty long. Consider breaking it up.

[nainar1, 2017-05-26 05:26:38]

nainar@google.com changed reviewers:
+ nainar@google.com

[nainar1, 2017-05-26 05:26:39]

meade@, 

Made the changes you asked for. 

Thanks!

https://codereview.chromium.org/2897193005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
(right):

https://codereview.chromium.org/2897193005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5:48:
"padding-bottom", "-webkit-highlight", "text-indent", "text-align-last",
"TextIndentLine", "EffectiveZoom", "word-break", "overflow-wrap",
"-webkit-line-break", "-webkit-text-security", "hyphens",
"HyphenationLimitBefore", "HyphenationLimitAfter",
"-webkit-hyphenate-character", "RespectImageOrientation",
"-webkit-ruby-position", "TextEmphasisMark", "TextEmphasisPosition",
"TextEmphasisCustomMark", "text-justify", "text-orientation",
"text-combine-upright", "tab-size", "text-size-adjust", "list-style-image",
"line-height-step", "-webkit-text-stroke-width", "line-height", "font",
"-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing",
"TextAutosizingMultiplier"],
On 2017/05/26 at 05:13:27, meade_UTC10 wrote:
> This line is getting pretty long. Consider breaking it up.

Done.

[nainar1, 2017-05-26 05:26:41]

The CQ bit was checked by nainar@google.com

[nainar1, 2017-05-26 05:26:41]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2897193005/#ps60001
(title: "meade@ suggestions")

[commit-bot: I haz the power, 2017-05-26 05:27:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 08:01:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495776401384130,
"parent_rev": "99af26c7d6c7f9d7843ab1f55b265556aabd6497", "commit_rev":
"3f6091b333bf47b3cb8650f11fe41aced37568a3"}

[commit-bot: I haz the power, 2017-05-26 08:01:14]

Description was changed from

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions
BUG=710938
==========

to

==========
Generate diffs for all fields on StyleRareInheritedData

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions
Review-Url: https://codereview.chromium.org/2897193005
Cr-Commit-Position: refs/heads/master@{#474959}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f6091b333bf47b3cb8650f11fe4...
==========

[commit-bot: I haz the power, 2017-05-26 08:01:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3f6091b333bf47b3cb8650f11fe4...