Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2897193005: Generate diffs for all fields on StyleRareInheritedData (Closed)
Patch Set: meade@ suggestions Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 fields_to_diff: { 8 fields_to_diff: {
9 default: [], 9 default: [],
10 }, 10 },
(...skipping 27 matching lines...) Expand all
38 methods_to_diff: [ 38 methods_to_diff: [
39 { 39 {
40 method: "GetPosition()", 40 method: "GetPosition()",
41 field_dependencies: ["position"] 41 field_dependencies: ["position"]
42 }, 42 },
43 ] 43 ]
44 }, 44 },
45 { 45 {
46 name: "DiffNeedsFullLayoutAndPaintInvalidation", 46 name: "DiffNeedsFullLayoutAndPaintInvalidation",
47 fields_to_diff: ["padding-top", "padding-left", "padding-right", 47 fields_to_diff: ["padding-top", "padding-left", "padding-right",
48 "padding-bottom", "line-height", "font", "-webkit-border-horizon tal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"], 48 "padding-bottom", "-webkit-highlight", "text-indent",
49 "text-align-last", "TextIndentLine", "EffectiveZoom",
50 "word-break", "overflow-wrap", "-webkit-line-break",
51 "-webkit-text-security", "hyphens", "HyphenationLimitBefore",
52 "HyphenationLimitAfter", "-webkit-hyphenate-character",
53 "RespectImageOrientation", "-webkit-ruby-position",
54 "TextEmphasisMark", "TextEmphasisPosition",
55 "TextEmphasisCustomMark", "text-justify", "text-orientation",
56 "text-combine-upright", "tab-size", "text-size-adjust",
57 "list-style-image", "line-height-step",
58 "-webkit-text-stroke-width", "line-height", "font",
59 "-webkit-border-horizontal-spacing",
60 "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"],
49 methods_to_diff: [ 61 methods_to_diff: [
50 { 62 {
51 method: "BorderLeftWidth()", 63 method: "BorderLeftWidth()",
52 field_dependencies: ["border-left-width"] 64 field_dependencies: ["border-left-width"]
53 }, 65 },
54 { 66 {
55 method: "BorderTopWidth()", 67 method: "BorderTopWidth()",
56 field_dependencies: ["border-top-width"] 68 field_dependencies: ["border-top-width"]
57 }, 69 },
58 { 70 {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 predicate: "TextShadowDataEquivalent(other)", 141 predicate: "TextShadowDataEquivalent(other)",
130 field_dependencies: ["text-shadow"] 142 field_dependencies: ["text-shadow"]
131 }, 143 },
132 { 144 {
133 predicate: "QuotesDataEquivalent(other)", 145 predicate: "QuotesDataEquivalent(other)",
134 field_dependencies: ["quotes"] 146 field_dependencies: ["quotes"]
135 }, 147 },
136 ] 148 ]
137 }, 149 },
138 { 150 {
151 name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayTableType",
152 methods_to_diff: [
153 {
154 method: "BorderCollapse()",
155 field_dependencies: ["border-collapse"]
156 },
157 {
158 method: "EmptyCells()",
159 field_dependencies: ["empty-cells"]
160 },
161 {
162 method: "CaptionSide()",
163 field_dependencies: ["caption-side"]
164 },
165 {
166 method: "TableLayout()",
167 field_dependencies: ["table-layout"]
168 },
169 ]
170 },
171 {
172 name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayListItem",
173 methods_to_diff: [
174 {
175 method: "ListStyleType()",
176 field_dependencies: ["list-style-type"]
177 },
178 {
179 method: "ListStylePosition()",
180 field_dependencies: ["list-style-position"]
181 },
182 ]
183 },
184 {
139 name: "DiffNeedsFullLayout", 185 name: "DiffNeedsFullLayout",
140 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] 186 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"]
141 }, 187 },
142 { 188 {
143 name: "DiffNeedsPaintInvalidationObject", 189 name: "DiffNeedsPaintInvalidationObject",
190 fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering" ],
144 methods_to_diff: [ 191 methods_to_diff: [
145 { 192 {
146 method: "Visibility()", 193 method: "Visibility()",
147 field_dependencies: ["visibility"] 194 field_dependencies: ["visibility"]
148 }, 195 },
149 { 196 {
150 method: "PrintColorAdjust()", 197 method: "PrintColorAdjust()",
151 field_dependencies: ["-webkit-print-color-adjust"] 198 field_dependencies: ["-webkit-print-color-adjust"]
152 }, 199 },
153 { 200 {
154 method: "InsideLink()", 201 method: "InsideLink()",
155 field_dependencies: ["InsideLink"] 202 field_dependencies: ["InsideLink"]
156 } 203 }
157 ] 204 ]
158 }, 205 },
159 { 206 {
160 name: "DiffNeedsVisualRectUpdate", 207 name: "DiffNeedsVisualRectUpdate",
161 methods_to_diff: [ 208 methods_to_diff: [
162 { 209 {
163 method: "Visibility()", 210 method: "Visibility()",
164 field_dependencies: ["visibility"] 211 field_dependencies: ["visibility"]
165 } 212 }
166 ] 213 ]
167 } 214 },
215 {
216 name: "UpdatePropertySpecificDifferencesTextDecorationOrColor",
217 fields_to_diff: ["TextEmphasisFill", "text-underline-position", "text-de coration-skip", "AppliedTextDecorations"],
218 methods_to_diff: [
219 {
220 method: "TextFillColor()",
221 field_dependencies: ["-webkit-text-fill-color"]
222 },
223 {
224 method: "TextStrokeColor()",
225 field_dependencies: ["-webkit-text-stroke-color"]
226 },
227 {
228 method: "TextEmphasisColor()",
229 field_dependencies: ["-webkit-text-emphasis-color"]
230 },
231 {
232 method: "VisitedLinkTextFillColor()",
233 field_dependencies: ["VisitedLinkTextFillColor"]
234 },
235 {
236 method: "VisitedLinkTextStrokeColor()",
237 field_dependencies: ["VisitedLinkTextStrokeColor"]
238 },
239 {
240 method: "VisitedLinkTextEmphasisColor()",
241 field_dependencies: ["VisitedLinkTextEmphasisColor"]
242 },
243 {
244 method: "CaretColor()",
245 field_dependencies: ["caret-color"]
246 },
247 {
248 method: "VisitedLinkCaretColor()",
249 field_dependencies: ["VisitedLinkCaretColor"]
250 },
251 ]
252 },
168 ], 253 ],
169 } 254 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698