Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2897193005: Generate diffs for all fields on StyleRareInheritedData (Closed)
Patch Set: Friend class Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 fields_to_diff: { 8 fields_to_diff: {
9 default: [], 9 default: [],
10 }, 10 },
(...skipping 27 matching lines...) Expand all
38 methods_to_diff: [ 38 methods_to_diff: [
39 { 39 {
40 method: "GetPosition()", 40 method: "GetPosition()",
41 field_dependencies: ["position"] 41 field_dependencies: ["position"]
42 }, 42 },
43 ] 43 ]
44 }, 44 },
45 { 45 {
46 name: "DiffNeedsFullLayoutAndPaintInvalidation", 46 name: "DiffNeedsFullLayoutAndPaintInvalidation",
47 fields_to_diff: ["padding-top", "padding-left", "padding-right", 47 fields_to_diff: ["padding-top", "padding-left", "padding-right",
48 "padding-bottom", "line-height", "font", "-webkit-border-horizon tal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"], 48 "padding-bottom", "-webkit-highlight", "text-indent", "text-alig n-last", "TextIndentLine", "EffectiveZoom", "word-break", "overflow-wrap", "-web kit-line-break", "-webkit-text-security", "hyphens", "HyphenationLimitBefore", " HyphenationLimitAfter", "-webkit-hyphenate-character", "RespectImageOrientation" , "-webkit-ruby-position", "TextEmphasisMark", "TextEmphasisPosition", "TextEmph asisCustomMark", "text-justify", "text-orientation", "text-combine-upright", "ta b-size", "text-size-adjust", "list-style-image", "line-height-step", "-webkit-te xt-stroke-width", "line-height", "font", "-webkit-border-horizontal-spacing", "- webkit-border-vertical-spacing", "TextAutosizingMultiplier"],
meade_UTC10 2017/05/26 05:13:27 This line is getting pretty long. Consider breakin
nainar1 2017/05/26 05:26:39 Done.
49 methods_to_diff: [ 49 methods_to_diff: [
50 { 50 {
51 method: "BorderLeftWidth()", 51 method: "BorderLeftWidth()",
52 field_dependencies: ["border-left-width"] 52 field_dependencies: ["border-left-width"]
53 }, 53 },
54 { 54 {
55 method: "BorderTopWidth()", 55 method: "BorderTopWidth()",
56 field_dependencies: ["border-top-width"] 56 field_dependencies: ["border-top-width"]
57 }, 57 },
58 { 58 {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 predicate: "TextShadowDataEquivalent(other)", 129 predicate: "TextShadowDataEquivalent(other)",
130 field_dependencies: ["text-shadow"] 130 field_dependencies: ["text-shadow"]
131 }, 131 },
132 { 132 {
133 predicate: "QuotesDataEquivalent(other)", 133 predicate: "QuotesDataEquivalent(other)",
134 field_dependencies: ["quotes"] 134 field_dependencies: ["quotes"]
135 }, 135 },
136 ] 136 ]
137 }, 137 },
138 { 138 {
139 name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayTableType",
140 methods_to_diff: [
141 {
142 method: "BorderCollapse()",
143 field_dependencies: ["border-collapse"]
144 },
145 {
146 method: "EmptyCells()",
147 field_dependencies: ["empty-cells"]
148 },
149 {
150 method: "CaptionSide()",
151 field_dependencies: ["caption-side"]
152 },
153 {
154 method: "TableLayout()",
155 field_dependencies: ["table-layout"]
156 },
157 ]
158 },
159 {
160 name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayListItem",
161 methods_to_diff: [
162 {
163 method: "ListStyleType()",
164 field_dependencies: ["list-style-type"]
165 },
166 {
167 method: "ListStylePosition()",
168 field_dependencies: ["list-style-position"]
169 },
170 ]
171 },
172 {
139 name: "DiffNeedsFullLayout", 173 name: "DiffNeedsFullLayout",
140 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] 174 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"]
141 }, 175 },
142 { 176 {
143 name: "DiffNeedsPaintInvalidationObject", 177 name: "DiffNeedsPaintInvalidationObject",
178 fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering" ],
144 methods_to_diff: [ 179 methods_to_diff: [
145 { 180 {
146 method: "Visibility()", 181 method: "Visibility()",
147 field_dependencies: ["visibility"] 182 field_dependencies: ["visibility"]
148 }, 183 },
149 { 184 {
150 method: "PrintColorAdjust()", 185 method: "PrintColorAdjust()",
151 field_dependencies: ["-webkit-print-color-adjust"] 186 field_dependencies: ["-webkit-print-color-adjust"]
152 }, 187 },
153 { 188 {
154 method: "InsideLink()", 189 method: "InsideLink()",
155 field_dependencies: ["InsideLink"] 190 field_dependencies: ["InsideLink"]
156 } 191 }
157 ] 192 ]
158 }, 193 },
159 { 194 {
160 name: "DiffNeedsVisualRectUpdate", 195 name: "DiffNeedsVisualRectUpdate",
161 methods_to_diff: [ 196 methods_to_diff: [
162 { 197 {
163 method: "Visibility()", 198 method: "Visibility()",
164 field_dependencies: ["visibility"] 199 field_dependencies: ["visibility"]
165 } 200 }
166 ] 201 ]
167 } 202 },
203 {
204 name: "UpdatePropertySpecificDifferencesTextDecorationOrColor",
205 fields_to_diff: ["TextEmphasisFill", "text-underline-position", "text-de coration-skip", "AppliedTextDecorations"],
206 methods_to_diff: [
207 {
208 method: "TextFillColor()",
209 field_dependencies: ["-webkit-text-fill-color"]
210 },
211 {
212 method: "TextStrokeColor()",
213 field_dependencies: ["-webkit-text-stroke-color"]
214 },
215 {
216 method: "TextEmphasisColor()",
217 field_dependencies: ["-webkit-text-emphasis-color"]
218 },
219 {
220 method: "VisitedLinkTextFillColor()",
221 field_dependencies: ["VisitedLinkTextFillColor"]
222 },
223 {
224 method: "VisitedLinkTextStrokeColor()",
225 field_dependencies: ["VisitedLinkTextStrokeColor"]
226 },
227 {
228 method: "VisitedLinkTextEmphasisColor()",
229 field_dependencies: ["VisitedLinkTextEmphasisColor"]
230 },
231 {
232 method: "CaretColor()",
233 field_dependencies: ["caret-color"]
234 },
235 {
236 method: "VisitedLinkCaretColor()",
237 field_dependencies: ["VisitedLinkCaretColor"]
238 },
239 ]
240 },
168 ], 241 ],
169 } 242 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698