Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2897193005: Generate diffs for all fields on StyleRareInheritedData (Closed)
Patch Set: meade@ suggestions Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 // bit fields, while large fields are stored in pointers and shared where not 160 // bit fields, while large fields are stored in pointers and shared where not
161 // modified from their parent value (see the DataRef class). 161 // modified from their parent value (see the DataRef class).
162 // 162 //
163 // Currently, ComputedStyle is hand-written and ComputedStyleBase is generated. 163 // Currently, ComputedStyle is hand-written and ComputedStyleBase is generated.
164 // Over time, methods will be moved to ComputedStyleBase and the generator will 164 // Over time, methods will be moved to ComputedStyleBase and the generator will
165 // be expanded to handle more and more types of properties. Eventually, all 165 // be expanded to handle more and more types of properties. Eventually, all
166 // methods will be on ComputedStyleBase (with custom methods defined in a class 166 // methods will be on ComputedStyleBase (with custom methods defined in a class
167 // such as ComputedStyleBase.cpp) and ComputedStyle will be removed. 167 // such as ComputedStyleBase.cpp) and ComputedStyle will be removed.
168 class CORE_EXPORT ComputedStyle : public ComputedStyleBase<ComputedStyle>, 168 class CORE_EXPORT ComputedStyle : public ComputedStyleBase<ComputedStyle>,
169 public RefCounted<ComputedStyle> { 169 public RefCounted<ComputedStyle> {
170 // Needed to allow access to private/protected getters of fields to allow diff
171 // generation
172 friend class ComputedStyleBase<ComputedStyle>;
170 // Used by Web Animations CSS. Sets the color styles. 173 // Used by Web Animations CSS. Sets the color styles.
171 friend class AnimatedStyleBuilder; 174 friend class AnimatedStyleBuilder;
172 // Used by Web Animations CSS. Gets visited and unvisited colors separately. 175 // Used by Web Animations CSS. Gets visited and unvisited colors separately.
173 friend class CSSAnimatableValueFactory; 176 friend class CSSAnimatableValueFactory;
174 // Used by CSS animations. We can't allow them to animate based off visited 177 // Used by CSS animations. We can't allow them to animate based off visited
175 // colors. 178 // colors.
176 friend class CSSPropertyEquality; 179 friend class CSSPropertyEquality;
177 // Editing has to only reveal unvisited info. 180 // Editing has to only reveal unvisited info.
178 friend class ApplyStyleCommand; 181 friend class ApplyStyleCommand;
179 // Editing has to only reveal unvisited info. 182 // Editing has to only reveal unvisited info.
(...skipping 3590 matching lines...) Expand 10 before | Expand all | Expand 10 after
3770 PseudoBitsInternal() | 1 << (pseudo - kFirstPublicPseudoId))); 3773 PseudoBitsInternal() | 1 << (pseudo - kFirstPublicPseudoId)));
3771 } 3774 }
3772 3775
3773 inline bool ComputedStyle::HasPseudoElementStyle() const { 3776 inline bool ComputedStyle::HasPseudoElementStyle() const {
3774 return PseudoBitsInternal() & kElementPseudoIdMask; 3777 return PseudoBitsInternal() & kElementPseudoIdMask;
3775 } 3778 }
3776 3779
3777 } // namespace blink 3780 } // namespace blink
3778 3781
3779 #endif // ComputedStyle_h 3782 #endif // ComputedStyle_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698