Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 2897143002: [CRD iOS] Ignore touch event when the touch point is out of the canvas in direct input mode (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Ignore touch event when the touch point is out of the canvas in direct input mode Previously if the user taps outside the bounds of the desktop canvas, GestureInterpreter will still attempt to inject the out-of-bound mouse event and show the touch feedback. The mouse event will be clamped back to the edge of the desktop (e.g. (50, -100) => (50, 0)). The Android client will ignore out-of-bound touch inputs in touch mode. This CL does the same thing for iOS client. BUG=718704 Review-Url: https://codereview.chromium.org/2897143002 Cr-Commit-Position: refs/heads/master@{#474057} Committed: https://chromium.googlesource.com/chromium/src/+/b932f1dd70ed60e43ca6fea500d01e155f2eae36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -20 lines) Patch
M remoting/client/ui/desktop_viewport.h View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/client/ui/desktop_viewport.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M remoting/client/ui/direct_input_strategy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/ui/direct_input_strategy.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M remoting/client/ui/gesture_interpreter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/client/ui/gesture_interpreter.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M remoting/client/ui/input_strategy.h View 1 chunk +5 lines, -1 line 0 comments Download
M remoting/client/ui/trackpad_input_strategy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/ui/trackpad_input_strategy.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuwei
PTAL thanks!
3 years, 7 months ago (2017-05-23 18:35:05 UTC) #2
nicholss
lgtm
3 years, 7 months ago (2017-05-23 20:47:08 UTC) #3
Yuwei
Thanks!
3 years, 7 months ago (2017-05-23 20:49:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897143002/1
3 years, 7 months ago (2017-05-23 20:50:17 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 21:19:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b932f1dd70ed60e43ca6fea500d0...

Powered by Google App Engine
This is Rietveld 408576698