Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2895883002: Make TextEmphasisPosition an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextEmphasisPosition an enum class. This patch makes TextEmphasisPosition an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2895883002 Cr-Commit-Position: refs/heads/master@{#474900} Committed: https://chromium.googlesource.com/chromium/src/+/78f5c551f8255dab868c0f32fb543748d9a0bfca

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainterBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 03:10:35 UTC) #3
rune
lgtm
3 years, 7 months ago (2017-05-24 06:17:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895883002/20001
3 years, 6 months ago (2017-05-26 03:27:20 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 03:33:28 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78f5c551f8255dab868c0f32fb54...

Powered by Google App Engine
This is Rietveld 408576698