Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2895883002: Make TextEmphasisPosition an enum class. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 1590 matching lines...) Expand 10 before | Expand all | Expand 10 after
1601 } 1601 }
1602 1602
1603 NOTREACHED(); 1603 NOTREACHED();
1604 return kRubyPositionBefore; 1604 return kRubyPositionBefore;
1605 } 1605 }
1606 1606
1607 template <> 1607 template <>
1608 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisPosition position) 1608 inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisPosition position)
1609 : CSSValue(kIdentifierClass) { 1609 : CSSValue(kIdentifierClass) {
1610 switch (position) { 1610 switch (position) {
1611 case kTextEmphasisPositionOver: 1611 case TextEmphasisPosition::kOver:
1612 value_id_ = CSSValueOver; 1612 value_id_ = CSSValueOver;
1613 break; 1613 break;
1614 case kTextEmphasisPositionUnder: 1614 case TextEmphasisPosition::kUnder:
1615 value_id_ = CSSValueUnder; 1615 value_id_ = CSSValueUnder;
1616 break; 1616 break;
1617 } 1617 }
1618 } 1618 }
1619 1619
1620 template <> 1620 template <>
1621 inline TextEmphasisPosition CSSIdentifierValue::ConvertTo() const { 1621 inline TextEmphasisPosition CSSIdentifierValue::ConvertTo() const {
1622 switch (value_id_) { 1622 switch (value_id_) {
1623 case CSSValueOver: 1623 case CSSValueOver:
1624 return kTextEmphasisPositionOver; 1624 return TextEmphasisPosition::kOver;
1625 case CSSValueUnder: 1625 case CSSValueUnder:
1626 return kTextEmphasisPositionUnder; 1626 return TextEmphasisPosition::kUnder;
1627 default: 1627 default:
1628 break; 1628 break;
1629 } 1629 }
1630 1630
1631 NOTREACHED(); 1631 NOTREACHED();
1632 return kTextEmphasisPositionOver; 1632 return TextEmphasisPosition::kOver;
1633 } 1633 }
1634 1634
1635 template <> 1635 template <>
1636 inline CSSIdentifierValue::CSSIdentifierValue(TextOverflow overflow) 1636 inline CSSIdentifierValue::CSSIdentifierValue(TextOverflow overflow)
1637 : CSSValue(kIdentifierClass) { 1637 : CSSValue(kIdentifierClass) {
1638 switch (overflow) { 1638 switch (overflow) {
1639 case kTextOverflowClip: 1639 case kTextOverflowClip:
1640 value_id_ = CSSValueClip; 1640 value_id_ = CSSValueClip;
1641 break; 1641 break;
1642 case kTextOverflowEllipsis: 1642 case kTextOverflowEllipsis:
(...skipping 1677 matching lines...) Expand 10 before | Expand all | Expand 10 after
3320 default: 3320 default:
3321 break; 3321 break;
3322 } 3322 }
3323 NOTREACHED(); 3323 NOTREACHED();
3324 return kContainsNone; 3324 return kContainsNone;
3325 } 3325 }
3326 3326
3327 } // namespace blink 3327 } // namespace blink
3328 3328
3329 #endif 3329 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698