Make TextEmphasisPosition an enum class.

third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
  *               All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 806 matching lines @@
                   : bottom_ruby_base_leading;
           box_height -= (top_ruby_base_leading + bottom_ruby_base_leading);
         }
       }
       if (curr->IsInlineTextBox()) {
         TextEmphasisPosition emphasis_mark_position;
         if (ToInlineTextBox(curr)->GetEmphasisMarkPosition(
                 curr->GetLineLayoutItem().StyleRef(IsFirstLineStyle()),
                 emphasis_mark_position)) {
           bool emphasis_mark_is_over =
-              emphasis_mark_position == kTextEmphasisPositionOver;
+              emphasis_mark_position == TextEmphasisPosition::kOver;
           if (emphasis_mark_is_over != curr->GetLineLayoutItem()
                                            .Style(IsFirstLineStyle())
                                            ->IsFlippedLinesWritingMode())
             has_annotations_before = true;
           else
             has_annotations_after = true;
         }
       }
 
       if (!set_line_top) {
@@ skipping 206 matching lines @@
   float top_glyph_overflow = -stroke_overflow - top_glyph_edge;
   float bottom_glyph_overflow = stroke_overflow + bottom_glyph_edge;
   float left_glyph_overflow = -stroke_overflow - left_glyph_edge;
   float right_glyph_overflow = stroke_overflow + right_glyph_edge;
 
   TextEmphasisPosition emphasis_mark_position;
   if (style.GetTextEmphasisMark() != kTextEmphasisMarkNone &&
       text_box->GetEmphasisMarkPosition(style, emphasis_mark_position)) {
     float emphasis_mark_height =
         style.GetFont().EmphasisMarkHeight(style.TextEmphasisMarkString());
-    if ((emphasis_mark_position == kTextEmphasisPositionOver) ==
+    if ((emphasis_mark_position == TextEmphasisPosition::kOver) ==
         (!style.IsFlippedLinesWritingMode()))
       top_glyph_overflow = std::min(top_glyph_overflow, -emphasis_mark_height);
     else
       bottom_glyph_overflow =
           std::max(bottom_glyph_overflow, emphasis_mark_height);
   }
 
   // If letter-spacing is negative, we should factor that into right layout
   // overflow. Even in RTL, letter-spacing is applied to the right, so this is
   // not an issue with left overflow.
@@ skipping 477 matching lines @@
       }
     }
 
     if (curr->IsInlineTextBox()) {
       const ComputedStyle& style =
           curr->GetLineLayoutItem().StyleRef(IsFirstLineStyle());
       TextEmphasisPosition emphasis_mark_position;
       if (style.GetTextEmphasisMark() != kTextEmphasisMarkNone &&
           ToInlineTextBox(curr)->GetEmphasisMarkPosition(
               style, emphasis_mark_position) &&
-          emphasis_mark_position == kTextEmphasisPositionOver) {
+          emphasis_mark_position == TextEmphasisPosition::kOver) {
         if (!style.IsFlippedLinesWritingMode()) {
           int top_of_emphasis_mark =
               (curr->LogicalTop() - style.GetFont().EmphasisMarkHeight(
                                         style.TextEmphasisMarkString()))
                   .ToInt();
           result = std::max(result, allowed_position - top_of_emphasis_mark);
         } else {
           int bottom_of_emphasis_mark =
               (curr->LogicalBottom() + style.GetFont().EmphasisMarkHeight(
                                            style.TextEmphasisMarkString()))
@@ skipping 47 matching lines @@
         bottom_of_last_ruby_text_line += curr->LogicalTop();
         result =
             std::max(result, bottom_of_last_ruby_text_line - allowed_position);
       }
     }
 
     if (curr->IsInlineTextBox()) {
       const ComputedStyle& style =
           curr->GetLineLayoutItem().StyleRef(IsFirstLineStyle());
       if (style.GetTextEmphasisMark() != kTextEmphasisMarkNone &&
-          style.GetTextEmphasisPosition() == kTextEmphasisPositionUnder) {
+          style.GetTextEmphasisPosition() == TextEmphasisPosition::kUnder) {
         if (!style.IsFlippedLinesWritingMode()) {
           LayoutUnit bottom_of_emphasis_mark =
               curr->LogicalBottom() + style.GetFont().EmphasisMarkHeight(
                                           style.TextEmphasisMarkString());
           result = std::max(result, bottom_of_emphasis_mark - allowed_position);
         } else {
           LayoutUnit top_of_emphasis_mark =
               curr->LogicalTop() - style.GetFont().EmphasisMarkHeight(
                                        style.TextEmphasisMarkString());
           result = std::max(result, allowed_position - top_of_emphasis_mark);
@@ skipping 76 matching lines @@
   InlineBox::ShowLineTreeAndMark(marked_box1, marked_label1, marked_box2,
                                  marked_label2, obj, depth);
   for (const InlineBox* box = FirstChild(); box; box = box->NextOnLine())
     box->ShowLineTreeAndMark(marked_box1, marked_label1, marked_box2,
                              marked_label2, obj, depth + 1);
 }
 
 #endif
 
 }  // namespace blink