Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2895883002: Make TextEmphasisPosition an enum class. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 6c07e882094a867bbe045319a66bc9cf7dfbe742..85ea4d830eeefc1a41d025e8a80becb378a69475 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1608,10 +1608,10 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisPosition position)
: CSSValue(kIdentifierClass) {
switch (position) {
- case kTextEmphasisPositionOver:
+ case TextEmphasisPosition::kOver:
value_id_ = CSSValueOver;
break;
- case kTextEmphasisPositionUnder:
+ case TextEmphasisPosition::kUnder:
value_id_ = CSSValueUnder;
break;
}
@@ -1621,15 +1621,15 @@ template <>
inline TextEmphasisPosition CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueOver:
- return kTextEmphasisPositionOver;
+ return TextEmphasisPosition::kOver;
case CSSValueUnder:
- return kTextEmphasisPositionUnder;
+ return TextEmphasisPosition::kUnder;
default:
break;
}
NOTREACHED();
- return kTextEmphasisPositionOver;
+ return TextEmphasisPosition::kOver;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698