Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 2895443002: Return Job as unique_ptr from factory methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by Bence
Modified:
3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Zhongyi Shi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return Job as unique_ptr from factory methods. Return HttpStreamFactoryImpl::Job as unique_ptr from CreateMainJob(), CreateAltSvcJob(), and CreateAltProxyJob() factory methods. BUG=475060 Review-Url: https://codereview.chromium.org/2895443002 Cr-Commit-Position: refs/heads/master@{#473002} Committed: https://chromium.googlesource.com/chromium/src/+/6b86d7c8b20f25282abef00a275c40ced632aab4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -29 lines) Patch
M net/http/http_stream_factory_impl_job.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_stream_factory_test_util.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_test_util.cc View 5 chunks +20 lines, -9 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (9 generated)
Bence
Ryan: PTAL. Thank you.
3 months ago (2017-05-18 19:46:21 UTC) #4
Ryan Hamilton
NICE! LGTM zhongyi: FYI
3 months ago (2017-05-18 21:43:54 UTC) #5
Zhongyi Shi
lgtm Nice! Thanks Bence!
3 months ago (2017-05-18 21:49:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895443002/1
3 months ago (2017-05-18 22:58:47 UTC) #11
commit-bot: I haz the power
3 months ago (2017-05-19 00:58:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b86d7c8b20f25282abef00a275c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b