net/http/http_stream_factory_impl_job.h - Issue 2895443002: Return Job as unique_ptr from factory methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 2895443002: Return Job as unique_ptr from factory methods. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_job.h

diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h

index 9605e8ff6198aec46a3a119139a3b3b0308de85d..11361536f1881623bf027d8ad81f0b60f2d26b10 100644

--- a/net/http/http_stream_factory_impl_job.h

+++ b/net/http/http_stream_factory_impl_job.h

@@ -493,7 +493,7 @@ class HttpStreamFactoryImpl::JobFactory {

virtual ~JobFactory();

- virtual HttpStreamFactoryImpl::Job* CreateMainJob(

+ virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateMainJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,

@@ -507,7 +507,7 @@ class HttpStreamFactoryImpl::JobFactory {

bool enable_ip_based_pooling,

NetLog* net_log);

- virtual HttpStreamFactoryImpl::Job* CreateAltSvcJob(

+ virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltSvcJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,

@@ -522,7 +522,7 @@ class HttpStreamFactoryImpl::JobFactory {

bool enable_ip_based_pooling,

NetLog* net_log);

- virtual HttpStreamFactoryImpl::Job* CreateAltProxyJob(

+ virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltProxyJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,

« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »