net/http/http_stream_factory_test_util.h - Issue 2895443002: Return Job as unique_ptr from factory methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_test_util.h

Issue 2895443002: Return Job as unique_ptr from factory methods. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_test_util.h

diff --git a/net/http/http_stream_factory_test_util.h b/net/http/http_stream_factory_test_util.h

index d958533c399941dbe9eefdd685d19fe0b880194b..1ee93e7825929ed79c5d7f151460d6a124362c33 100644

--- a/net/http/http_stream_factory_test_util.h

+++ b/net/http/http_stream_factory_test_util.h

@@ -136,7 +136,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

TestJobFactory();

~TestJobFactory() override;

- HttpStreamFactoryImpl::Job* CreateMainJob(

+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateMainJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,

@@ -150,7 +150,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

bool enable_ip_based_pooling,

NetLog* net_log) override;

- HttpStreamFactoryImpl::Job* CreateAltSvcJob(

+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltSvcJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,

@@ -165,7 +165,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

bool enable_ip_based_pooling,

NetLog* net_log) override;

- HttpStreamFactoryImpl::Job* CreateAltProxyJob(

+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltProxyJob(

HttpStreamFactoryImpl::Job::Delegate* delegate,

HttpStreamFactoryImpl::JobType job_type,

HttpNetworkSession* session,