Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: net/http/http_stream_factory_test_util.h

Issue 2895443002: Return Job as unique_ptr from factory methods. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.cc ('k') | net/http/http_stream_factory_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_test_util.h
diff --git a/net/http/http_stream_factory_test_util.h b/net/http/http_stream_factory_test_util.h
index d958533c399941dbe9eefdd685d19fe0b880194b..1ee93e7825929ed79c5d7f151460d6a124362c33 100644
--- a/net/http/http_stream_factory_test_util.h
+++ b/net/http/http_stream_factory_test_util.h
@@ -136,7 +136,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
TestJobFactory();
~TestJobFactory() override;
- HttpStreamFactoryImpl::Job* CreateMainJob(
+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateMainJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
@@ -150,7 +150,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
bool enable_ip_based_pooling,
NetLog* net_log) override;
- HttpStreamFactoryImpl::Job* CreateAltSvcJob(
+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltSvcJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
@@ -165,7 +165,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
bool enable_ip_based_pooling,
NetLog* net_log) override;
- HttpStreamFactoryImpl::Job* CreateAltProxyJob(
+ std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltProxyJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller.cc ('k') | net/http/http_stream_factory_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698