Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: net/http/http_stream_factory_impl_job.h

Issue 2895443002: Return Job as unique_ptr from factory methods. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_ 5 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
6 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_ 6 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 DISALLOW_COPY_AND_ASSIGN(Job); 486 DISALLOW_COPY_AND_ASSIGN(Job);
487 }; 487 };
488 488
489 // Factory for creating Jobs. 489 // Factory for creating Jobs.
490 class HttpStreamFactoryImpl::JobFactory { 490 class HttpStreamFactoryImpl::JobFactory {
491 public: 491 public:
492 JobFactory(); 492 JobFactory();
493 493
494 virtual ~JobFactory(); 494 virtual ~JobFactory();
495 495
496 virtual HttpStreamFactoryImpl::Job* CreateMainJob( 496 virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateMainJob(
497 HttpStreamFactoryImpl::Job::Delegate* delegate, 497 HttpStreamFactoryImpl::Job::Delegate* delegate,
498 HttpStreamFactoryImpl::JobType job_type, 498 HttpStreamFactoryImpl::JobType job_type,
499 HttpNetworkSession* session, 499 HttpNetworkSession* session,
500 const HttpRequestInfo& request_info, 500 const HttpRequestInfo& request_info,
501 RequestPriority priority, 501 RequestPriority priority,
502 const ProxyInfo& proxy_info, 502 const ProxyInfo& proxy_info,
503 const SSLConfig& server_ssl_config, 503 const SSLConfig& server_ssl_config,
504 const SSLConfig& proxy_ssl_config, 504 const SSLConfig& proxy_ssl_config,
505 HostPortPair destination, 505 HostPortPair destination,
506 GURL origin_url, 506 GURL origin_url,
507 bool enable_ip_based_pooling, 507 bool enable_ip_based_pooling,
508 NetLog* net_log); 508 NetLog* net_log);
509 509
510 virtual HttpStreamFactoryImpl::Job* CreateAltSvcJob( 510 virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltSvcJob(
511 HttpStreamFactoryImpl::Job::Delegate* delegate, 511 HttpStreamFactoryImpl::Job::Delegate* delegate,
512 HttpStreamFactoryImpl::JobType job_type, 512 HttpStreamFactoryImpl::JobType job_type,
513 HttpNetworkSession* session, 513 HttpNetworkSession* session,
514 const HttpRequestInfo& request_info, 514 const HttpRequestInfo& request_info,
515 RequestPriority priority, 515 RequestPriority priority,
516 const ProxyInfo& proxy_info, 516 const ProxyInfo& proxy_info,
517 const SSLConfig& server_ssl_config, 517 const SSLConfig& server_ssl_config,
518 const SSLConfig& proxy_ssl_config, 518 const SSLConfig& proxy_ssl_config,
519 HostPortPair destination, 519 HostPortPair destination,
520 GURL origin_url, 520 GURL origin_url,
521 AlternativeService alternative_service, 521 AlternativeService alternative_service,
522 bool enable_ip_based_pooling, 522 bool enable_ip_based_pooling,
523 NetLog* net_log); 523 NetLog* net_log);
524 524
525 virtual HttpStreamFactoryImpl::Job* CreateAltProxyJob( 525 virtual std::unique_ptr<HttpStreamFactoryImpl::Job> CreateAltProxyJob(
526 HttpStreamFactoryImpl::Job::Delegate* delegate, 526 HttpStreamFactoryImpl::Job::Delegate* delegate,
527 HttpStreamFactoryImpl::JobType job_type, 527 HttpStreamFactoryImpl::JobType job_type,
528 HttpNetworkSession* session, 528 HttpNetworkSession* session,
529 const HttpRequestInfo& request_info, 529 const HttpRequestInfo& request_info,
530 RequestPriority priority, 530 RequestPriority priority,
531 const ProxyInfo& proxy_info, 531 const ProxyInfo& proxy_info,
532 const SSLConfig& server_ssl_config, 532 const SSLConfig& server_ssl_config,
533 const SSLConfig& proxy_ssl_config, 533 const SSLConfig& proxy_ssl_config,
534 HostPortPair destination, 534 HostPortPair destination,
535 GURL origin_url, 535 GURL origin_url,
536 const ProxyServer& alternative_proxy_server, 536 const ProxyServer& alternative_proxy_server,
537 bool enable_ip_based_pooling, 537 bool enable_ip_based_pooling,
538 NetLog* net_log); 538 NetLog* net_log);
539 }; 539 };
540 540
541 } // namespace net 541 } // namespace net
542 542
543 #endif // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_ 543 #endif // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698