Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2891933004: Remove raw base::DictionaryValue::Set in //content

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 2 hours ago by jdoerrie - OOO til May 29th
Modified:
4 days, 21 hours ago
Reviewers:
CC:
chromium-reviews, tzik, posciak+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, jam, net-reviews_chromium.org, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, einbinder+watch-test-runner_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, dtseng+watch_chromium.org, eroman, Peter Beverloo, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, piman+watch_chromium.org, jsbell+idb_chromium.org, jochen+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, mlamouri+watch-test-runner_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, nektar+watch_chromium.org, bnc+watch_chromium.org, kinuko+serviceworker, mmenke, cmumford, horo+watch_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove raw base::DictionaryValue::Set in //content This change removes the deprecated raw pointer version of base::DictionaryValue::Set in //content and replaces it with the unique pointer version or other convenience functions where appropriate. BUG=646113, 581865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -167 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_auralinux.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_blink.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_ui.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/system_info_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/compositor_util.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 3 chunks +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 14 chunks +46 lines, -43 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/media_internals.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/media/media_internals_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/media_internals_proxy.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M content/browser/net/network_errors_listing_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/webrtc/webrtc_internals.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M content/shell/browser/shell_devtools_bindings.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/shell/browser/shell_net_log.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/leak_detector.cc View 2 chunks +23 lines, -20 lines 0 comments Download
M net/log/net_log.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/log/net_log.cc View 3 chunks +7 lines, -6 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (4 generated)
jdoerrie - OOO til May 29th
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
5 days, 2 hours ago (2017-05-19 15:42:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891933004/1
5 days, 2 hours ago (2017-05-19 15:42:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 days, 21 hours ago (2017-05-19 20:17:46 UTC) #3
commit-bot: I haz the power
4 days, 21 hours ago (2017-05-19 20:17:47 UTC) #4
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06