Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: net/log/net_log.h

Issue 2891933004: Remove raw base::DictionaryValue::Set in //content (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/layout_test/leak_detector.cc ('k') | net/log/net_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log.h
diff --git a/net/log/net_log.h b/net/log/net_log.h
index 41e8cc64e83bd3e7a03f25febb754342cfb37fc4..0a10808c53bbc9dad88ac6478e5ddfafe1a210d9 100644
--- a/net/log/net_log.h
+++ b/net/log/net_log.h
@@ -154,15 +154,15 @@ class NET_EXPORT NetLog {
static const char* EventTypeToString(NetLogEventType event_type);
// Returns a dictionary that maps event type symbolic names to their enum
- // values. Caller takes ownership of the returned Value.
- static base::Value* GetEventTypesAsValue();
+ // values.
+ static std::unique_ptr<base::Value> GetEventTypesAsValue();
// Returns a C-String symbolic name for |source_type|.
static const char* SourceTypeToString(NetLogSourceType source_type);
// Returns a dictionary that maps source type symbolic names to their enum
- // values. Caller takes ownership of the returned Value.
- static base::Value* GetSourceTypesAsValue();
+ // values.
+ static std::unique_ptr<base::Value> GetSourceTypesAsValue();
// Returns a C-String symbolic name for |event_phase|.
static const char* EventPhaseToString(NetLogEventPhase event_phase);
« no previous file with comments | « content/shell/renderer/layout_test/leak_detector.cc ('k') | net/log/net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698