content/browser/net/network_errors_listing_ui.cc - Issue 2891933004: Remove raw base::DictionaryValue::Set in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/net/network_errors_listing_ui.cc

Issue 2891933004: Remove raw base::DictionaryValue::Set in //content (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/net/network_errors_listing_ui.cc

diff --git a/content/browser/net/network_errors_listing_ui.cc b/content/browser/net/network_errors_listing_ui.cc

index 86ed0bb068b9b7cde66885493ffe3d571606dff0..976970151cdbe00f96c32914a4f3597815fe887f 100644

--- a/content/browser/net/network_errors_listing_ui.cc

+++ b/content/browser/net/network_errors_listing_ui.cc

@@ -64,7 +64,7 @@ bool HandleRequestCallback(BrowserContext* current_context,

return false;

base::DictionaryValue data;

- data.Set(kErrorCodesDataName, GetNetworkErrorData().release());

+ data.Set(kErrorCodesDataName, GetNetworkErrorData());

std::string json_string;

base::JSONWriter::Write(data, &json_string);

callback.Run(base::RefCountedString::TakeString(&json_string));