Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6114)

Unified Diff: content/browser/media/media_internals_proxy.h

Issue 2891933004: Remove raw base::DictionaryValue::Set in //content (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/media_internals.cc ('k') | content/browser/media/media_internals_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_internals_proxy.h
diff --git a/content/browser/media/media_internals_proxy.h b/content/browser/media/media_internals_proxy.h
index f0995e3355cb56d75ec2380ac1e81943bc133c73..a9dbba46163c39917133e6f7ee9e8be944e07c33 100644
--- a/content/browser/media/media_internals_proxy.h
+++ b/content/browser/media/media_internals_proxy.h
@@ -60,7 +60,7 @@ class MediaInternalsProxy
~MediaInternalsProxy() override;
// Build a dictionary mapping constant names to values.
- base::Value* GetConstants();
+ std::unique_ptr<base::Value> GetConstants();
void ObserveMediaInternalsOnIOThread();
void StopObservingMediaInternalsOnIOThread();
@@ -75,9 +75,9 @@ class MediaInternalsProxy
// Send all pending events to the page.
void SendNetEventsOnUIThread();
- // Call a JavaScript function on the page. Takes ownership of |args|.
+ // Call a JavaScript function on the page.
void CallJavaScriptFunctionOnUIThread(const std::string& function,
- base::Value* args);
+ std::unique_ptr<base::Value> args);
MediaInternalsMessageHandler* handler_;
std::unique_ptr<base::ListValue> pending_net_updates_;
« no previous file with comments | « content/browser/media/media_internals.cc ('k') | content/browser/media/media_internals_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698