Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2891843002: build: Remove build system support for gold plugin, except under ChromeOS.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 18 hours ago by pcc1
Modified:
4 days, 13 hours ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Remove build system support for gold plugin, except under ChromeOS. R=thakis@chromium.org,brettw@chromium.org TBR=mseaborn@chromium.org BUG=607968

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase past https://codereview.chromium.org/2888623003 which removed the dependency on use_lld in g… #

Patch Set 3 : Only allow gold plugin with ChromeOS #

Messages

Total messages: 26 (18 generated)
pcc1
6 days, 18 hours ago (2017-05-17 23:12:04 UTC) #1
Nico
lgtm, but a question. Also, when relanding CLs, please upload the original CL as patch ...
6 days, 18 hours ago (2017-05-17 23:14:29 UTC) #6
pcc1
https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compiler.gni File build/config/compiler/compiler.gni (right): https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compiler.gni#newcode126 build/config/compiler/compiler.gni:126: ((allow_posix_link_time_opt || is_cfi) && target_os == "linux" && It ...
6 days, 18 hours ago (2017-05-17 23:22:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891843002/20001
6 days ago (2017-05-18 17:38:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430947)
5 days, 18 hours ago (2017-05-18 22:54:47 UTC) #14
pcc1
4 days, 19 hours ago (2017-05-19 22:10:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891843002/40001
4 days, 17 hours ago (2017-05-20 00:35:28 UTC) #24
commit-bot: I haz the power
4 days, 13 hours ago (2017-05-20 04:00:14 UTC) #26
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06