Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2953953002: Revert of build: Remove build system support for gold plugin, except under ChromeOS. (Closed)

Created:
3 years, 6 months ago by fsamuel
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of build: Remove build system support for gold plugin, except under ChromeOS. (patchset #5 id:80001 of https://codereview.chromium.org/2891843002/ ) Reason for revert: Suspecting this CL for generate_build_files failure: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/18593 Original issue's description: > build: Remove build system support for gold plugin, except under ChromeOS. > > R=thakis@chromium.org,brettw@chromium.org > TBR=mseaborn@chromium.org > BUG=607968 > > Review-Url: https://codereview.chromium.org/2891843002 > Cr-Commit-Position: refs/heads/master@{#481656} > Committed: https://chromium.googlesource.com/chromium/src/+/84bbf436692e8b91ba238f11a4749fd2c4d99cb7 TBR=brettw@chromium.org,thakis@chromium.org,mseaborn@chromium.org,yunlian@chromium.org,pcc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607968 Review-Url: https://codereview.chromium.org/2953953002 Cr-Commit-Position: refs/heads/master@{#481673} Committed: https://chromium.googlesource.com/chromium/src/+/e92354177987b98fdbdd0a44f069eb209d770adc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/win/DebugVisualizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
fsamuel
Created Revert of build: Remove build system support for gold plugin, except under ChromeOS.
3 years, 6 months ago (2017-06-22 21:38:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953953002/1
3 years, 6 months ago (2017-06-22 21:38:20 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 21:38:22 UTC) #5
pcc1
lgtm
3 years, 6 months ago (2017-06-22 21:39:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2953953002/1
3 years, 6 months ago (2017-06-22 21:42:39 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 21:43:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e92354177987b98fdbdd0a44f069...

Powered by Google App Engine
This is Rietveld 408576698