build: Remove build system support for gold plugin, except under ChromeOS.

build: Remove build system support for gold plugin, except under ChromeOS.

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
Review-Url: https://codereview.chromium.org/2891843002
Cr-Commit-Position: refs/heads/master@{#481656}
Committed: https://chromium.googlesource.com/chromium/src/+/84bbf436692e8b91ba238f11a4749fd2c4d99cb7

[pcc1, 2017-05-17 23:12:18]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[pcc1, 2017-05-17 23:12:41]

Description was changed from

==========
build: Remove build system support for gold plugin, take 2.

The previous attempt needed to be reverted [1] because it broke the
CFI build bots, which enable LTO by setting only is_cfi. This CL
changes the default value of use_lld to depend on is_cfi, so that
enabling only is_cfi still works.

This required moving the definition of use_lld to a place where the
is_cfi flag is available, and fixing the resulting dependency issues.

[1] https://codereview.chromium.org/2892643002

R=thakis@chromium.org,brettw@chromium.org
BUG=607968
==========

to

==========
build: Remove build system support for gold plugin, take 2.

The previous attempt needed to be reverted [1] because it broke the
CFI build bots, which enable LTO by setting only is_cfi. This CL
changes the default value of use_lld to depend on is_cfi, so that
enabling only is_cfi still works.

This required moving the definition of use_lld to a place where the
is_cfi flag is available, and fixing the resulting dependency issues.

[1] https://codereview.chromium.org/2892643002

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

[pcc1, 2017-05-17 23:12:42]

pcc@chromium.org changed reviewers:
+ mseaborn@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:13:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-17 23:14:29]

lgtm, but a question.

Also, when relanding CLs, please upload the original CL as patch set 1 and the
changed one as patch set 2, so that it's easy to see what changed.

https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:126: ((allow_posix_link_time_opt || is_cfi)
&& target_os == "linux" &&
Shouldn't is_cfi imply allow_posix_link_time_opt? CFI requires LTO, no?

[pcc1, 2017-05-17 23:22:37]

https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2891843002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:126: ((allow_posix_link_time_opt || is_cfi)
&& target_os == "linux" &&
It could do, I think. I'll see if I can do that as a separate cleanup.

[commit-bot: I haz the power, 2017-05-18 05:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 05:05:05]

Dry run: This issue passed the CQ dry run.

[pcc1, 2017-05-18 17:36:49]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-05-18 17:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2891843002/#ps20001
(title: "Rebase past https://codereview.chromium.org/2888623003 which removed
the dependency on use_lld in g…")

[commit-bot: I haz the power, 2017-05-18 17:38:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:54:47]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pcc1, 2017-05-19 22:09:55]

Description was changed from

==========
build: Remove build system support for gold plugin, take 2.

The previous attempt needed to be reverted [1] because it broke the
CFI build bots, which enable LTO by setting only is_cfi. This CL
changes the default value of use_lld to depend on is_cfi, so that
enabling only is_cfi still works.

This required moving the definition of use_lld to a place where the
is_cfi flag is available, and fixing the resulting dependency issues.

[1] https://codereview.chromium.org/2892643002

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

to

==========
build: Remove build system support for gold plugin, except under ChromeOS.

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

[pcc1, 2017-05-19 22:10:11]

pcc@chromium.org changed reviewers:
+ yunlian@chromium.org

[pcc1, 2017-05-19 22:48:19]

The CQ bit was checked by pcc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:48:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 00:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 00:26:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pcc1, 2017-05-20 00:34:39]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-05-20 00:34:40]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2891843002/#ps40001
(title: "Only allow gold plugin with ChromeOS")

[commit-bot: I haz the power, 2017-05-20 00:35:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 04:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 04:00:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pcc1, 2017-06-22 18:39:00]

LLD has stuck for almost a month at this point, so I'll make another attempt to
land this.

[pcc1, 2017-06-22 18:39:08]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2017-06-22 18:39:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 18:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 18:42:17]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pcc1, 2017-06-22 18:59:38]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-06-22 18:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2891843002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-22 18:59:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 19:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 19:10:12]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pcc1, 2017-06-22 19:18:12]

The CQ bit was checked by pcc@chromium.org

[pcc1, 2017-06-22 19:18:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2891843002/#ps80001
(title: "Attempt to fix the Windows build")

[commit-bot: I haz the power, 2017-06-22 19:18:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 20:48:57]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498159092090790,
"parent_rev": "8af61ebffa92e8d012cb0a9046bcf91aa7762ece", "commit_rev":
"84bbf436692e8b91ba238f11a4749fd2c4d99cb7"}

[commit-bot: I haz the power, 2017-06-22 20:49:15]

Description was changed from

==========
build: Remove build system support for gold plugin, except under ChromeOS.

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968
==========

to

==========
build: Remove build system support for gold plugin, except under ChromeOS.

R=thakis@chromium.org,brettw@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2891843002
Cr-Commit-Position: refs/heads/master@{#481656}
Committed:
https://chromium.googlesource.com/chromium/src/+/84bbf436692e8b91ba238f11a474...
==========

[commit-bot: I haz the power, 2017-06-22 20:49:16]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/84bbf436692e8b91ba238f11a474...

[fsamuel, 2017-06-22 21:38:01]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2953953002/ by fsamuel@google.com.

The reason for reverting is: Suspecting this CL for generate_build_files
failure:
https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro....