Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2892643002: Revert of build: Remove build system support for gold plugin. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Mark Seaborn, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of build: Remove build system support for gold plugin. (patchset #2 id:20001 of https://codereview.chromium.org/2891513002/ ) Reason for revert: Broke CFI buildbots: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20CF https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT Need build file fixes to make is_cfi imply use_lld. Original issue's description: > build: Remove build system support for gold plugin. > > R=thakis@chromium.org > TBR=mseaborn@chromium.org > BUG=607968 > > Review-Url: https://codereview.chromium.org/2891513002 > Cr-Commit-Position: refs/heads/master@{#472258} > Committed: https://chromium.googlesource.com/chromium/src/+/5d98fe2426808ddc4c9526a49ce63db2ace279c2 TBR=thakis@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607968 Review-Url: https://codereview.chromium.org/2892643002 Cr-Commit-Position: refs/heads/master@{#472516} Committed: https://chromium.googlesource.com/chromium/src/+/76561105b5060a8fcfe39463eddbc60a3f776fb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M build/config/compiler/BUILD.gn View 4 chunks +25 lines, -12 lines 0 comments Download
M chrome/test/data/nacl/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
pcc1
Created Revert of build: Remove build system support for gold plugin.
3 years, 7 months ago (2017-05-17 18:58:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892643002/1
3 years, 7 months ago (2017-05-17 18:59:55 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:00:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76561105b5060a8fcfe39463eddb...

Powered by Google App Engine
This is Rietveld 408576698