Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/gritsettings/resource_ids

Issue 2891793002: Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. (Closed)
Patch Set: Addressed comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gritsettings/resource_ids
diff --git a/tools/gritsettings/resource_ids b/tools/gritsettings/resource_ids
index 5221b60daec2d4094b40a4ac6b2547bc47eeaea6..8e4d4831d7935aa92308280a7fde12d33e82a3f7 100644
--- a/tools/gritsettings/resource_ids
+++ b/tools/gritsettings/resource_ids
@@ -30,24 +30,20 @@
#
# chrome/ and ios/chrome/ must start at the same id.
# App only use one file depending on whether it is iOS or other platform.
- "chrome/app/address_input_strings.grd": {
- "messages": [400],
- },
-
# Chromium strings and Google Chrome strings must start at the same id.
# We only use one file depending on whether we're building Chromium or
# Google Chrome.
"chrome/app/chromium_strings.grd": {
- "messages": [500],
+ "messages": [400],
},
"chrome/app/google_chrome_strings.grd": {
- "messages": [500],
+ "messages": [400],
},
# Leave lots of space for generated_resources since it has most of our
# strings.
"chrome/app/generated_resources.grd": {
- "messages": [900],
+ "messages": [800],
},
"chrome/app/resources/locale_settings.grd": {
@@ -358,6 +354,11 @@
"includes": [28600],
"messages": [28650],
},
+
+ # TODO(crbug.com/672458): Move this out of src/chrome/.
+ "chrome/app/address_input_strings.grd": {
+ "messages": [28700],
+ },
# END "everything else" section.
# Everything but chrome/, components/, content/, and ios/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698