Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tools/gritsettings/resource_ids

Issue 2891793002: Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. (Closed)
Patch Set: Addressed comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 # 4 #
5 # This file is used to assign starting resource ids for resources and strings 5 # This file is used to assign starting resource ids for resources and strings
6 # used by Chromium. This is done to ensure that resource ids are unique 6 # used by Chromium. This is done to ensure that resource ids are unique
7 # across all the grd files. If you are adding a new grd file, please add 7 # across all the grd files. If you are adding a new grd file, please add
8 # a new entry to this file. 8 # a new entry to this file.
9 # 9 #
10 # The entries below are organized into sections. When adding new entries, 10 # The entries below are organized into sections. When adding new entries,
(...skipping 12 matching lines...) Expand all
23 # The first entry in the file, SRCDIR, is special: It is a relative path from 23 # The first entry in the file, SRCDIR, is special: It is a relative path from
24 # this file to the base of your checkout. 24 # this file to the base of your checkout.
25 "SRCDIR": "../..", 25 "SRCDIR": "../..",
26 26
27 # START chrome/app section. 27 # START chrome/app section.
28 # Previous versions of this file started with resource id 400, so stick with 28 # Previous versions of this file started with resource id 400, so stick with
29 # that. 29 # that.
30 # 30 #
31 # chrome/ and ios/chrome/ must start at the same id. 31 # chrome/ and ios/chrome/ must start at the same id.
32 # App only use one file depending on whether it is iOS or other platform. 32 # App only use one file depending on whether it is iOS or other platform.
33 "chrome/app/address_input_strings.grd": {
34 "messages": [400],
35 },
36
37 # Chromium strings and Google Chrome strings must start at the same id. 33 # Chromium strings and Google Chrome strings must start at the same id.
38 # We only use one file depending on whether we're building Chromium or 34 # We only use one file depending on whether we're building Chromium or
39 # Google Chrome. 35 # Google Chrome.
40 "chrome/app/chromium_strings.grd": { 36 "chrome/app/chromium_strings.grd": {
41 "messages": [500], 37 "messages": [400],
42 }, 38 },
43 "chrome/app/google_chrome_strings.grd": { 39 "chrome/app/google_chrome_strings.grd": {
44 "messages": [500], 40 "messages": [400],
45 }, 41 },
46 42
47 # Leave lots of space for generated_resources since it has most of our 43 # Leave lots of space for generated_resources since it has most of our
48 # strings. 44 # strings.
49 "chrome/app/generated_resources.grd": { 45 "chrome/app/generated_resources.grd": {
50 "messages": [900], 46 "messages": [800],
51 }, 47 },
52 48
53 "chrome/app/resources/locale_settings.grd": { 49 "chrome/app/resources/locale_settings.grd": {
54 "messages": [10000], 50 "messages": [10000],
55 }, 51 },
56 52
57 # These each start with the same resource id because we only use one 53 # These each start with the same resource id because we only use one
58 # file for each build (chromiumos, google_chromeos, linux, mac, or win). 54 # file for each build (chromiumos, google_chromeos, linux, mac, or win).
59 "chrome/app/resources/locale_settings_chromiumos.grd": { 55 "chrome/app/resources/locale_settings_chromiumos.grd": {
60 "messages": [10100], 56 "messages": [10100],
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 "includes": [28450], 347 "includes": [28450],
352 }, 348 },
353 "devtools_resources.grd": { 349 "devtools_resources.grd": {
354 "includes": [28450], 350 "includes": [28450],
355 }, 351 },
356 352
357 "cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd": { 353 "cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd": {
358 "includes": [28600], 354 "includes": [28600],
359 "messages": [28650], 355 "messages": [28650],
360 }, 356 },
357
358 # TODO(crbug.com/672458): Move this out of src/chrome/.
359 "chrome/app/address_input_strings.grd": {
360 "messages": [28700],
361 },
361 # END "everything else" section. 362 # END "everything else" section.
362 # Everything but chrome/, components/, content/, and ios/ 363 # Everything but chrome/, components/, content/, and ios/
363 364
364 # Thinking about appending to the end? 365 # Thinking about appending to the end?
365 # Please read the header and find the right section above instead. 366 # Please read the header and find the right section above instead.
366 367
367 # Resource ids starting at 31000 are reserved for projects built on Chromium. 368 # Resource ids starting at 31000 are reserved for projects built on Chromium.
368 } 369 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698