Bootstrapping: Send meaningful error code/message from Slave to Master

Bootstrapping: Send meaningful error code/message from Slave to Master using the following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32, "Policy validation error"], ...
[4*, "other error"]

BUG=695235
TEST=Manually

Review-Url: https://codereview.chromium.org/2890383003
Cr-Commit-Position: refs/heads/master@{#480858}
Committed: https://chromium.googlesource.com/chromium/src/+/74b40e5f9f72ee12fa5292e5c1cbc4c9fe378432

[xdai1, 2017-05-22 19:12:54]

Description was changed from

==========
Bootstrapping: Send meaningful error code/message from Slave to Master

BUG=695235
==========

to

==========
Bootstrapping: Send meaningful error code/message from Slave to Master using the
following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32,
"Policy validation error"], ...
[4*, "other error"]

BUG=695235
==========

[xdai1, 2017-05-22 19:13:37]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:14:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:59:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xdai1, 2017-05-22 20:40:47]

Patchset #1 (id:1) has been deleted

[xdai1, 2017-05-22 20:41:00]

Patchset #1 (id:20001) has been deleted

[xdai1, 2017-05-22 20:41:07]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 20:41:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 21:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 21:19:56]

Dry run: This issue passed the CQ dry run.

[xdai1, 2017-05-23 21:35:54]

Description was changed from

==========
Bootstrapping: Send meaningful error code/message from Slave to Master using the
following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32,
"Policy validation error"], ...
[4*, "other error"]

BUG=695235
==========

to

==========
Bootstrapping: Send meaningful error code/message from Slave to Master using the
following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32,
"Policy validation error"], ...
[4*, "other error"]

BUG=695235
TEST=Manually
==========

[xdai1, 2017-05-23 21:36:14]

xdai@chromium.org changed reviewers:
+ achuith@chromium.org

[xdai1, 2017-05-23 21:36:14]

achuith@, could you help review this CL please? Thanks!

[achuithb, 2017-05-25 19:25:54]

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:40: const char kInvalidJsonError[] =
"Invalid JSON Dictionary";
Does this not need to be translated?

Also, I think we prefer constexpr

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:181: LOG(ERROR) << kInvalidJsonError <<
": " << error;
Move this to right after the if statement?

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.h:15: #include
"chromeos/network/network_handler_callbacks.h"
Please forward declare ErrorCallback instead

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:164:
std::stoi(std::to_string(HostPairingController::AUTH_ERROR) +
What's going on here?

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/network_screen.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/network_screen.h:10: #include
"base/compiler_specific.h"
Also include base/callback_forward.h for base::Closure

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/network_screen.h:20: #include
"chromeos/network/network_handler_callbacks.h"
Please forward declare

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/wizard_controller.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/wizard_controller.h:31: #include
"chromeos/network/network_handler_callbacks.h"
Forward declare

https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
File components/pairing/host_pairing_controller.h (right):

https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
components/pairing/host_pairing_controller.h:54: enum ErrorCode {
We now prefer enum class.

[achuithb, 2017-05-25 19:27:34]

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:164:
std::stoi(std::to_string(HostPairingController::AUTH_ERROR) +
On 2017/05/25 19:25:53, achuithb wrote:
> What's going on here?

I think I understand.

Can't we multiply the prefix by 10 and add numbers instead of converting back
and forth from strings?

Also, please add comments

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.h:89: int
enrollment_error_code_ = 0;
ERROR_NONE?

[xdai1, 2017-06-08 22:18:41]

achuith@, I'm sorry for the late reply. I've addressed the comments. Please take
another look, thanks for the review！

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:40: const char kInvalidJsonError[] =
"Invalid JSON Dictionary";
On 2017/05/25 19:25:53, achuithb wrote:
> Does this not need to be translated?
> 
> Also, I think we prefer constexpr

Done. I think it should be fine to leave it untranslated. This error info will
only be visible to the admain admin for error diagnosis.

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:181: LOG(ERROR) << kInvalidJsonError <<
": " << error;
On 2017/05/25 19:25:53, achuithb wrote:
> Move this to right after the if statement?

Done.

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.h:15: #include
"chromeos/network/network_handler_callbacks.h"
On 2017/05/25 19:25:53, achuithb wrote:
> Please forward declare ErrorCallback instead

It's a type def so can't be forward declared.

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:164:
std::stoi(std::to_string(HostPairingController::AUTH_ERROR) +
On 2017/05/25 19:27:34, achuithb wrote:
> On 2017/05/25 19:25:53, achuithb wrote:
> > What's going on here?
> 
> I think I understand.
> 
> Can't we multiply the prefix by 10 and add numbers instead of converting back
> and forth from strings?
> 
> Also, please add comments

Added comments in the definition in the header file.

The reason I used stoi and to_string back and force is the error number is not
necessarily a one-digit number (e.g., ATTRIBUTE_UPDATE_FAILED enum number is
14). We probably can multiply the prefix by 100 but it seems a little weird for
a one-digit error. What do you think?

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.h:89: int
enrollment_error_code_ = 0;
On 2017/05/25 19:27:34, achuithb wrote:
> ERROR_NONE?

Using 0 here might be better than using
static_cast<int>(HostPairingController::ErrorCode::ERROR_NONE) here as
|enrollment_error_code_| may be a value that is not in the enum class
HostPairingController::ErrorCode.

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/network_screen.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/network_screen.h:10: #include
"base/compiler_specific.h"
On 2017/05/25 19:25:53, achuithb wrote:
> Also include base/callback_forward.h for base::Closure

Done.

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/network_screen.h:20: #include
"chromeos/network/network_handler_callbacks.h"
On 2017/05/25 19:25:53, achuithb wrote:
> Please forward declare

ditto

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/wizard_controller.h (right):

https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/wizard_controller.h:31: #include
"chromeos/network/network_handler_callbacks.h"
On 2017/05/25 19:25:53, achuithb wrote:
> Forward declare

It's not used. Removed the include file.

https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
File components/pairing/host_pairing_controller.h (right):

https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
components/pairing/host_pairing_controller.h:54: enum ErrorCode {
On 2017/05/25 19:25:54, achuithb wrote:
> We now prefer enum class.

Done. I'll update the other enums in another CL to make them consistent.

[xdai1, 2017-06-08 22:18:45]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 22:19:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 22:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 22:51:37]

Dry run: This issue passed the CQ dry run.

[xdai1, 2017-06-14 00:18:47]

On 2017/06/08 22:18:41, xdai1 wrote:
> achuith@, I'm sorry for the late reply. I've addressed the comments. Please
take
> another look, thanks for the review！
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/helper.cc (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/helper.cc:40: const char kInvalidJsonError[] =
> "Invalid JSON Dictionary";
> On 2017/05/25 19:25:53, achuithb wrote:
> > Does this not need to be translated?
> > 
> > Also, I think we prefer constexpr
> 
> Done. I think it should be fine to leave it untranslated. This error info will
> only be visible to the admain admin for error diagnosis.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/helper.cc:181: LOG(ERROR) << kInvalidJsonError
<<
> ": " << error;
> On 2017/05/25 19:25:53, achuithb wrote:
> > Move this to right after the if statement?
> 
> Done.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/helper.h (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/helper.h:15: #include
> "chromeos/network/network_handler_callbacks.h"
> On 2017/05/25 19:25:53, achuithb wrote:
> > Please forward declare ErrorCallback instead
> 
> It's a type def so can't be forward declared.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/host_pairing_screen.cc:164:
> std::stoi(std::to_string(HostPairingController::AUTH_ERROR) +
> On 2017/05/25 19:27:34, achuithb wrote:
> > On 2017/05/25 19:25:53, achuithb wrote:
> > > What's going on here?
> > 
> > I think I understand.
> > 
> > Can't we multiply the prefix by 10 and add numbers instead of converting
back
> > and forth from strings?
> > 
> > Also, please add comments
> 
> Added comments in the definition in the header file.
> 
> The reason I used stoi and to_string back and force is the error number is not
> necessarily a one-digit number (e.g., ATTRIBUTE_UPDATE_FAILED enum number is
> 14). We probably can multiply the prefix by 100 but it seems a little weird
for
> a one-digit error. What do you think?
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/host_pairing_screen.h (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/host_pairing_screen.h:89: int
> enrollment_error_code_ = 0;
> On 2017/05/25 19:27:34, achuithb wrote:
> > ERROR_NONE?
> 
> Using 0 here might be better than using
> static_cast<int>(HostPairingController::ErrorCode::ERROR_NONE) here as
> |enrollment_error_code_| may be a value that is not in the enum class
> HostPairingController::ErrorCode.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/network_screen.h (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/network_screen.h:10: #include
> "base/compiler_specific.h"
> On 2017/05/25 19:25:53, achuithb wrote:
> > Also include base/callback_forward.h for base::Closure
> 
> Done.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/network_screen.h:20: #include
> "chromeos/network/network_handler_callbacks.h"
> On 2017/05/25 19:25:53, achuithb wrote:
> > Please forward declare
> 
> ditto
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/wizard_controller.h (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/wizard_controller.h:31: #include
> "chromeos/network/network_handler_callbacks.h"
> On 2017/05/25 19:25:53, achuithb wrote:
> > Forward declare
> 
> It's not used. Removed the include file.
> 
>
https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
> File components/pairing/host_pairing_controller.h (right):
> 
>
https://codereview.chromium.org/2890383003/diff/40001/components/pairing/host...
> components/pairing/host_pairing_controller.h:54: enum ErrorCode {
> On 2017/05/25 19:25:54, achuithb wrote:
> > We now prefer enum class.
> 
> Done. I'll update the other enums in another CL to make them consistent.

[xdai1, 2017-06-14 00:20:25]

Sorry pressed the mouse too quickly without entering any text... kindly ping,
Could you take another look at the CL?

[xdai1, 2017-06-16 00:13:12]

ping again?

[achuithb, 2017-06-17 00:12:00]

Sorry about the delay

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:179: new base::DictionaryValue);
base::MakeUnique?

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:169:
std::stoi(std::to_string(static_cast<int>(
As per offline discussion, pull this out into a utility function and add
comments explaining why string concatenation is preferred to arithmetic
addition.

[xdai1, 2017-06-19 18:15:00]

Thanks for the review!

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.cc:179: new base::DictionaryValue);
On 2017/06/17 00:11:59, achuithb wrote:
> base::MakeUnique?

Done.

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:169:
std::stoi(std::to_string(static_cast<int>(
On 2017/06/17 00:11:59, achuithb wrote:
> As per offline discussion, pull this out into a utility function and add
> comments explaining why string concatenation is preferred to arithmetic
> addition.

Done.

[xdai1, 2017-06-19 18:15:03]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 18:15:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 18:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:52:45]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-06-19 22:57:28]

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:20: // Gets the
fine-grained enrollment error code. It's calculated by concatenated
concatenating

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:22: // string
concatenation is preferred to arithmetic addition is the number of the
is that the number of sub error

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:27: std::string
sub_error_code) {
This should be const std::string&

And we cannot use an int here? I realize sub_error_codes are all different
enums.

[xdai1, 2017-06-19 23:45:11]

achuith@, I've addressed your comments. Please take anotehr look, thanks for the
review!

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/host_pairing_screen.cc (right):

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:20: // Gets the
fine-grained enrollment error code. It's calculated by concatenated
On 2017/06/19 22:57:27, achuithb wrote:
> concatenating

Done.

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:22: // string
concatenation is preferred to arithmetic addition is the number of the
On 2017/06/19 22:57:27, achuithb wrote:
> is that the number of sub error

Done.

https://codereview.chromium.org/2890383003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/host_pairing_screen.cc:27: std::string
sub_error_code) {
On 2017/06/19 22:57:27, achuithb wrote:
> This should be const std::string&
> 
> And we cannot use an int here? I realize sub_error_codes are all different
> enums.

Yes, you're right. int is better here. Thanks!

[xdai1, 2017-06-19 23:45:20]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 23:45:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-06-19 23:48:50]

lgtm. Thanks for your patience!

[commit-bot: I haz the power, 2017-06-20 01:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 01:48:57]

Dry run: This issue passed the CQ dry run.

[xdai1, 2017-06-20 16:44:13]

On 2017/06/19 23:48:50, achuithb wrote:
> lgtm. Thanks for your patience!

Thanks for the review!

[xdai1, 2017-06-20 16:44:20]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2017-06-20 16:44:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 16:49:34]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497977060847930,
"parent_rev": "a63f808c1d2a320fc3d657170b07b5eea9738bda", "commit_rev":
"74b40e5f9f72ee12fa5292e5c1cbc4c9fe378432"}

[commit-bot: I haz the power, 2017-06-20 16:49:47]

Description was changed from

==========
Bootstrapping: Send meaningful error code/message from Slave to Master using the
following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32,
"Policy validation error"], ...
[4*, "other error"]

BUG=695235
TEST=Manually
==========

to

==========
Bootstrapping: Send meaningful error code/message from Slave to Master using the
following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32,
"Policy validation error"], ...
[4*, "other error"]

BUG=695235
TEST=Manually

Review-Url: https://codereview.chromium.org/2890383003
Cr-Commit-Position: refs/heads/master@{#480858}
Committed:
https://chromium.googlesource.com/chromium/src/+/74b40e5f9f72ee12fa5292e5c1cb...
==========

[commit-bot: I haz the power, 2017-06-20 16:49:48]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/74b40e5f9f72ee12fa5292e5c1cb...