Bootstrapping: Send meaningful error code/message from Slave to Master

chrome/browser/chromeos/login/helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains helper functions used by Chromium OS login.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
+#include "chromeos/network/network_handler_callbacks.h"

[achuithb, 2017/05/25 19:25:53]

Please forward declare ErrorCallback instead

[xdai1, 2017/06/08 22:18:40]

It's a type def so can't be forward declared.

 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/views/view.h"
 
 namespace gfx {
 class Rect;
 class Size;
 }  // namespace gfx
 
 namespace content {
 class StoragePartition;
@@ skipping 41 matching lines @@
   // Get current connected Wifi network configuration. Used in shark/remora
   // mode. Note currently only unsecured Wifi network configuration can be
   // gotten since there is no way to get password for a secured Wifi newwork
   // in Cros for security reasons.
   virtual void GetConnectedWifiNetwork(std::string* out_onc_spec);
 
   // Add and apply a network configuration. Used in shark/remora mode.
   virtual void CreateAndConnectNetworkFromOnc(
       const std::string& onc_spec,
       const base::Closure& success_callback,
-      const base::Closure& error_callback) const;
+      const network_handler::ErrorCallback& error_callback) const;
 
   // Returns true if the default network is in connected state.
   virtual bool IsConnected() const;
 
   // Returns true if the default network is in connecting state.
   virtual bool IsConnecting() const;
 
  private:
-  void OnCreateConfiguration(const base::Closure& success_callback,
-                             const base::Closure& error_callback,
-                             const std::string& service_path,
-                             const std::string& guid) const;
-  void OnCreateOrConnectNetworkFailed(
-      const base::Closure& error_callback,
-      const std::string& error_name,
-      std::unique_ptr<base::DictionaryValue> error_data) const;
+  void OnCreateConfiguration(
+      const base::Closure& success_callback,
+      const network_handler::ErrorCallback& error_callback,
+      const std::string& service_path,
+      const std::string& guid) const;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkStateHelper);
 };
 
 //
 // Webview based login helpers.
 //
 
 // Returns the storage partition for the sign-in webview. Note the function gets
 // the partition via the sign-in WebContents thus returns nullptr if the sign-in
 // webui is torn down.
 content::StoragePartition* GetSigninPartition();
 
 // Returns the request context that contains sign-in cookies. For old iframe
 // based flow, the context of the sign-in profile is returned. For webview based
 // flow, the context of the sign-in webview storage partition is returned.
 net::URLRequestContextGetter* GetSigninContext();
 
 }  // namespace login
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_