Bootstrapping: Send meaningful error code/message from Slave to Master

chrome/browser/chromeos/login/screens/network_screen.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_
 
 #include <memory>
 
 #include "base/compiler_specific.h"

[achuithb, 2017/05/25 19:25:53]

Also include base/callback_forward.h for base::Closure

[xdai1, 2017/06/08 22:18:41]

Done.

 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chromeos/login/screens/base_screen.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chromeos/network/network_handler_callbacks.h"

[achuithb, 2017/05/25 19:25:53]

Please forward declare

[xdai1, 2017/06/08 22:18:41]

ditto

 #include "chromeos/network/network_state_handler_observer.h"
 #include "ui/base/ime/chromeos/input_method_manager.h"
 
 namespace chromeos {
 
 class InputEventsBlocker;
 class NetworkView;
 class ScreenManager;
 
 namespace locale_util {
@@ skipping 49 matching lines @@
                                           const std::string& input_method);
   std::string GetApplicationLocale();
   std::string GetInputMethod() const;
 
   void SetTimezone(const std::string& timezone_id);
   std::string GetTimezone() const;
 
   // Currently We can only get unsecured Wifi network configuration from shark
   // that can be applied to remora. Returns the network ONC configuration.
   void GetConnectedWifiNetwork(std::string* out_onc_spec);
-  void CreateAndConnectNetworkFromOnc(const std::string& onc_spec,
-                                      const base::Closure& success_callback,
-                                      const base::Closure& failed_callback);
+  void CreateAndConnectNetworkFromOnc(
+      const std::string& onc_spec,
+      const base::Closure& success_callback,
+      const network_handler::ErrorCallback& error_callback);
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  private:
   friend class NetworkScreenTest;
   friend class NetworkScreenUnitTest;
   FRIEND_TEST_ALL_PREFIXES(NetworkScreenTest, Timeout);
   FRIEND_TEST_ALL_PREFIXES(NetworkScreenTest, CanConnect);
   FRIEND_TEST_ALL_PREFIXES(NetworkScreenUnitTest, ContinuesAutomatically);
@@ skipping 111 matching lines @@
   base::ObserverList<Observer> observers_;
 
   base::WeakPtrFactory<NetworkScreen> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkScreen);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_NETWORK_SCREEN_H_