Bootstrapping: Send meaningful error code/message from Slave to Master

chrome/browser/chromeos/login/screens/host_pairing_screen.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screens/host_pairing_screen.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/enrollment_status_chromeos.h"
 #include "components/pairing/host_pairing_controller.h"
+#include "google_apis/gaia/google_service_auth_error.h"
 
 namespace chromeos {
 
 using namespace host_pairing;
 using namespace pairing_chromeos;
 
 HostPairingScreen::HostPairingScreen(
     BaseScreenDelegate* base_screen_delegate,
     Delegate* delegate,
     HostPairingScreenView* view,
@@ skipping 128 matching lines @@
       HostPairingController::ENROLLMENT_STATUS_ENROLLING);
 }
 
 void HostPairingScreen::OnViewDestroyed(HostPairingScreenView* view) {
   if (view_ == view)
     view_ = NULL;
 }
 
 void HostPairingScreen::OnAuthError(const GoogleServiceAuthError& error) {
   enrollment_error_string_ = view_->GetErrorStringFromAuthError(error);
+  enrollment_error_code_ =
+      std::stoi(std::to_string(HostPairingController::AUTH_ERROR) +

[achuithb, 2017/05/25 19:25:53]

What's going on here?

[achuithb, 2017/05/25 19:27:34]

I think I understand.

Can't we multiply the prefix by 10 and add numbers instead of converting back
and forth from strings?

Also, please add comments

[xdai1, 2017/06/08 22:18:40]

Added comments in the definition in the header file.

The reason I used stoi and to_string back and force is the error number is not
necessarily a one-digit number (e.g., ATTRIBUTE_UPDATE_FAILED enum number is
14). We probably can multiply the prefix by 100 but it seems a little weird for
a one-digit error. What do you think?

+                std::to_string(error.state()));
   OnAnyEnrollmentError();
 }
 
 void HostPairingScreen::OnEnrollmentError(policy::EnrollmentStatus status) {
   enrollment_error_string_ = view_->GetErrorStringFromEnrollmentError(status);
+  enrollment_error_code_ =
+      std::stoi(std::to_string(HostPairingController::ENROLL_ERROR) +
+                std::to_string(status.status()));
   OnAnyEnrollmentError();
 }
 
 void HostPairingScreen::OnOtherError(
     EnterpriseEnrollmentHelper::OtherError error) {
   enrollment_error_string_ = view_->GetErrorStringFromOtherError(error);
+  enrollment_error_code_ =
+      std::stoi(std::to_string(HostPairingController::OTHER_ERROR) +
+                std::to_string(error));
   OnAnyEnrollmentError();
 }
 
 void HostPairingScreen::OnDeviceEnrolled(const std::string& additional_token) {
   StartupUtils::MarkDeviceRegistered(base::Bind(&base::DoNothing));
   enrollment_helper_->ClearAuth(base::Bind(&HostPairingScreen::OnAuthCleared,
                                            weak_ptr_factory_.GetWeakPtr()));
 
   policy::BrowserPolicyConnectorChromeOS* connector =
       g_browser_process->platform_part()->browser_policy_connector_chromeos();
   const enterprise_management::PolicyData* policy =
       connector->GetDeviceCloudPolicyManager()->core()->store()->policy();
 
   remora_controller_->SetPermanentId(policy->directory_api_id());
   remora_controller_->OnEnrollmentStatusChanged(
       HostPairingController::ENROLLMENT_STATUS_SUCCESS);
 }
 
 void HostPairingScreen::OnDeviceAttributeUploadCompleted(bool success) {}
 
 void HostPairingScreen::OnDeviceAttributeUpdatePermission(bool granted) {}
 
 void HostPairingScreen::OnAuthCleared() {
   enrollment_helper_.reset();
 }
 
 void HostPairingScreen::OnAnyEnrollmentError() {
   enrollment_helper_->ClearAuth(base::Bind(&HostPairingScreen::OnAuthCleared,
                                            weak_ptr_factory_.GetWeakPtr()));
+  remora_controller_->SetErrorCodeAndMessage(enrollment_error_code_,
+                                             enrollment_error_string_);
   remora_controller_->OnEnrollmentStatusChanged(
       HostPairingController::ENROLLMENT_STATUS_FAILURE);
 }
 
 }  // namespace chromeos