web_dev_style: Fix errors in new directories and enable PRESUBMIT

web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2889113002
Cr-Commit-Position: refs/heads/master@{#472980}
Committed: https://chromium.googlesource.com/chromium/src/+/229bcc24f4239dae6c676c583cebc3e68d13dca2

[Dan Beam, 2017-05-18 02:25:37]

Description was changed from

==========
web_dev_style: Fix all errors in ui/webui/ and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
==========

to

==========
web_dev_style: Fix all errors in ui/webui/ and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-18 02:25:53]

Description was changed from

==========
web_dev_style: Fix all errors in ui/webui/ and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in ui/webui/ and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-18 02:45:39]

Description was changed from

==========
web_dev_style: Fix errors in ui/webui/ and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in:
- ui/webui/
- components/about_ui/
- components/flags_ui/
- components/version_ui/
and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-18 02:46:17]

Description was changed from

==========
web_dev_style: Fix errors in:
- ui/webui/
- components/about_ui/
- components/flags_ui/
- components/version_ui/
and enable PRESUBMIT

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- ui/webui/
- components/about_ui/
- components/flags_ui/
- components/version_ui/

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-18 02:46:55]

Description was changed from

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- ui/webui/
- components/about_ui/
- components/flags_ui/
- components/version_ui/

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-18 02:47:08]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 02:48:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-05-18 02:54:14]

Description was changed from

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-18 03:08:31]

lgtm! This is a great change, thanks for putting in the effort to make it happen

[commit-bot: I haz the power, 2017-05-18 04:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:21:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-05-18 17:19:32]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:20:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:31:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2017-05-18 18:01:48]

Patchset #3 (id:40001) has been deleted

[Dan Beam, 2017-05-18 18:02:25]

https://codereview.chromium.org/2889113002/diff/60001/tools/web_dev_style/htm...
File tools/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2889113002/diff/60001/tools/web_dev_style/htm...
tools/web_dev_style/html_checker.py:91: include_deletes=False)
.change.AffectedFiles -> AffectedFiles fixes checking outside of presubmit dir

[Dan Beam, 2017-05-18 18:02:29]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-05-18 18:02:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2889113002/#ps60001
(title: "merge+fix")

[commit-bot: I haz the power, 2017-05-18 18:04:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-05-18 21:54:03]

https://codereview.chromium.org/2889113002/diff/60001/tools/web_dev_style/htm...
File tools/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2889113002/diff/60001/tools/web_dev_style/htm...
tools/web_dev_style/html_checker.py:91: include_deletes=False)
On 2017/05/18 18:02:25, Dan Beam wrote:
> .change.AffectedFiles -> AffectedFiles fixes checking outside of presubmit dir

Great, thanks!

[commit-bot: I haz the power, 2017-05-18 23:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:50:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Dan Beam, 2017-05-18 23:53:45]

Description was changed from

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

[Dan Beam, 2017-05-18 23:53:49]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:55:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:06:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495151629544030,
"parent_rev": "b89328b48bc2ae3366c506cb32adb996e0493685", "commit_rev":
"229bcc24f4239dae6c676c583cebc3e68d13dca2"}

[commit-bot: I haz the power, 2017-05-19 00:06:49]

Description was changed from

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
==========

to

==========
web_dev_style: Fix errors in new directories and enable PRESUBMIT

Now fixed and checked:

- components/about_ui/
- components/flags_ui/
- components/version_ui/
- ui/webui/

Shockingly, nothing in components/ really had any errors, but that's
likely from them being copied from c/b/r and not being changed very
often (or me reviewing the changes closely in some cases).

R=tsergeant@chromium.org
BUG=723234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2889113002
Cr-Commit-Position: refs/heads/master@{#472980}
Committed:
https://chromium.googlesource.com/chromium/src/+/229bcc24f4239dae6c676c583ceb...
==========

[commit-bot: I haz the power, 2017-05-19 00:06:51]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/229bcc24f4239dae6c676c583ceb...