Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: tools/web_dev_style/presubmit_support.py

Issue 2889113002: web_dev_style: Fix errors in new directories and enable PRESUBMIT (Closed)
Patch Set: merge+fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/web_dev_style/presubmit_support.py
diff --git a/tools/web_dev_style/presubmit_support.py b/tools/web_dev_style/presubmit_support.py
index 3be6d6d67b251b67cdadfe762981252635c8b36a..09da59450a88f9ab7240b4d2ac1a632bd99d58df 100644
--- a/tools/web_dev_style/presubmit_support.py
+++ b/tools/web_dev_style/presubmit_support.py
@@ -9,14 +9,15 @@ import js_checker
import resource_checker
-def CheckStyle(input_api, output_api):
+def CheckStyle(input_api, output_api, file_filter=lambda f: True):
apis = input_api, output_api
is_resource = lambda f: f.LocalPath().endswith(('.html', '.css', '.js'))
+ wrapped_filter = lambda f: file_filter(f) and is_resource(f)
checkers = [
- css_checker.CSSChecker(*apis, file_filter=is_resource),
- html_checker.HtmlChecker(*apis, file_filter=is_resource),
- js_checker.JSChecker(*apis, file_filter=is_resource),
- resource_checker.ResourceChecker(*apis, file_filter=is_resource),
+ css_checker.CSSChecker(*apis, file_filter=wrapped_filter),
+ html_checker.HtmlChecker(*apis, file_filter=wrapped_filter),
+ js_checker.JSChecker(*apis, file_filter=wrapped_filter),
+ resource_checker.ResourceChecker(*apis, file_filter=wrapped_filter),
]
results = []
for checker in checkers:

Powered by Google App Engine
This is Rietveld 408576698