Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ui/webui/resources/js/cr/ui/bubble.js

Issue 2889113002: web_dev_style: Fix errors in new directories and enable PRESUBMIT (Closed)
Patch Set: merge+fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/web_dev_style/html_checker.py ('K') | « ui/webui/resources/css/list.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/bubble.js
diff --git a/ui/webui/resources/js/cr/ui/bubble.js b/ui/webui/resources/js/cr/ui/bubble.js
index fe9703062ea44ed11851a90db373ed6b21ce0ba7..abb8a5aa3759abac941b9267e3fca83d3e62c2a5 100644
--- a/ui/webui/resources/js/cr/ui/bubble.js
+++ b/ui/webui/resources/js/cr/ui/bubble.js
@@ -182,13 +182,13 @@ cr.define('cr.ui', function() {
var left = this.arrowAtRight_ ?
anchorMid + BubbleBase.ARROW_OFFSET - bubble.width :
anchorMid - BubbleBase.ARROW_OFFSET;
- var max_left_pos =
+ var maxLeftPos =
documentWidth - bubble.width - BubbleBase.MIN_VIEWPORT_EDGE_MARGIN;
- var min_left_pos = BubbleBase.MIN_VIEWPORT_EDGE_MARGIN;
+ var minLeftPos = BubbleBase.MIN_VIEWPORT_EDGE_MARGIN;
if (document.documentElement.dir == 'rtl')
- left = Math.min(Math.max(left, min_left_pos), max_left_pos);
+ left = Math.min(Math.max(left, minLeftPos), maxLeftPos);
else
- left = Math.max(Math.min(left, max_left_pos), min_left_pos);
+ left = Math.max(Math.min(left, maxLeftPos), minLeftPos);
var arrowTip = Math.min(
Math.max(
arrow.width / 2, this.arrowAtRight_ ?
« tools/web_dev_style/html_checker.py ('K') | « ui/webui/resources/css/list.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698