OLD | NEW |
---|---|
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """ | 5 """ |
6 Presubmit for Chromium HTML resources. See chrome/browser/PRESUBMIT.py. | 6 Presubmit for Chromium HTML resources. See chrome/browser/PRESUBMIT.py. |
7 """ | 7 """ |
8 | 8 |
9 import regex_check | 9 import regex_check |
10 | 10 |
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
80 regex = self.input_api.re.compile(r"=(\[\[|\{\{)") | 80 regex = self.input_api.re.compile(r"=(\[\[|\{\{)") |
81 return regex_check.RegexCheck(self.input_api.re, line_number, line, regex, | 81 return regex_check.RegexCheck(self.input_api.re, line_number, line, regex, |
82 'Please use quotes around Polymer bindings (i.e. attr="[[prop]]")') | 82 'Please use quotes around Polymer bindings (i.e. attr="[[prop]]")') |
83 | 83 |
84 def RunChecks(self): | 84 def RunChecks(self): |
85 """Check for violations of the Chromium web development style guide. See | 85 """Check for violations of the Chromium web development style guide. See |
86 https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/we b.md | 86 https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/we b.md |
87 """ | 87 """ |
88 results = [] | 88 results = [] |
89 | 89 |
90 affected_files = self.input_api.change.AffectedFiles( | 90 affected_files = self.input_api.AffectedFiles(file_filter=self.file_filter, |
91 file_filter=self.file_filter, include_deletes=False) | 91 include_deletes=False) |
Dan Beam
2017/05/18 18:02:25
.change.AffectedFiles -> AffectedFiles fixes check
tsergeant
2017/05/18 21:54:03
Great, thanks!
| |
92 | 92 |
93 for f in affected_files: | 93 for f in affected_files: |
94 if not f.LocalPath().endswith('.html'): | 94 if not f.LocalPath().endswith('.html'): |
95 continue | 95 continue |
96 | 96 |
97 errors = [] | 97 errors = [] |
98 | 98 |
99 for line_number, line in f.ChangedContents(): | 99 for line_number, line in f.ChangedContents(): |
100 errors.extend(filter(None, [ | 100 errors.extend(filter(None, [ |
101 self.ClassesUseDashFormCheck(line_number, line), | 101 self.ClassesUseDashFormCheck(line_number, line), |
102 self.DoNotCloseSingleTagsCheck(line_number, line), | 102 self.DoNotCloseSingleTagsCheck(line_number, line), |
103 self.DoNotUseBrElementCheck(line_number, line), | 103 self.DoNotUseBrElementCheck(line_number, line), |
104 self.DoNotUseInputTypeButtonCheck(line_number, line), | 104 self.DoNotUseInputTypeButtonCheck(line_number, line), |
105 self.I18nContentJavaScriptCaseCheck(line_number, line), | 105 self.I18nContentJavaScriptCaseCheck(line_number, line), |
106 self.LabelCheck(line_number, line), | 106 self.LabelCheck(line_number, line), |
107 self.QuotePolymerBindings(line_number, line), | 107 self.QuotePolymerBindings(line_number, line), |
108 ])) | 108 ])) |
109 | 109 |
110 if errors: | 110 if errors: |
111 abs_local_path = f.AbsoluteLocalPath() | 111 abs_local_path = f.AbsoluteLocalPath() |
112 file_indicator = 'Found HTML style issues in %s' % abs_local_path | 112 file_indicator = 'Found HTML style issues in %s' % abs_local_path |
113 prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n' | 113 prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n' |
114 results.append(self.output_api.PresubmitPromptWarning(prompt_msg)) | 114 results.append(self.output_api.PresubmitPromptWarning(prompt_msg)) |
115 | 115 |
116 return results | 116 return results |
OLD | NEW |