Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
RyanSturm, Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for counting same-document AMP loads. Though we can't track timing metrics like FCP for same-document loads, we can at least track how freqently they occur. This can help to understand how significant the performance of non-same-document AMP loads is, relative to the set of all AMP loads (both same doc and non same doc). BUG=722690 Review-Url: https://codereview.chromium.org/2888673002 Cr-Commit-Position: refs/heads/master@{#472802} Committed: https://chromium.googlesource.com/chromium/src/+/db2e320286b9752ed94f1bc6aa5e87eabe8eba6f

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : comment #

Patch Set 4 : comment cleanup #

Total comments: 4

Patch Set 5 : address comments #

Patch Set 6 : rebase, and small updates #

Total comments: 2

Patch Set 7 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -26 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc View 1 2 3 4 5 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h View 1 2 3 4 5 6 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc View 1 2 3 4 5 8 chunks +58 lines, -6 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc View 1 2 3 4 5 2 chunks +58 lines, -4 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.h View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.cc View 1 2 3 4 5 1 chunk +10 lines, -2 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (26 generated)
Bryan McQuade
PTAL, thanks!
3 years, 7 months ago (2017-05-16 19:57:50 UTC) #8
RyanSturm
lgtm % a comment and question. https://codereview.chromium.org/2888673002/diff/60001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h (right): https://codereview.chromium.org/2888673002/diff/60001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h#newcode30 chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h:30: void OnDidFinishSubFrameNavigation( Is ...
3 years, 7 months ago (2017-05-16 22:32:11 UTC) #9
Bryan McQuade
https://codereview.chromium.org/2888673002/diff/60001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h (right): https://codereview.chromium.org/2888673002/diff/60001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h#newcode30 chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h:30: void OnDidFinishSubFrameNavigation( On 2017/05/16 at 22:32:10, RyanSturm wrote: > ...
3 years, 7 months ago (2017-05-17 12:38:34 UTC) #14
Bryan McQuade
isherman, PTAL for histograms.xml change, thanks!
3 years, 7 months ago (2017-05-17 12:38:57 UTC) #16
Ilya Sherman
Metrics LGTM % a nit: https://codereview.chromium.org/2888673002/diff/100001/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h (right): https://codereview.chromium.org/2888673002/diff/100001/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h#newcode29 chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h:29: enum class AMPViewType { ...
3 years, 7 months ago (2017-05-17 19:26:43 UTC) #23
Bryan McQuade
https://codereview.chromium.org/2888673002/diff/100001/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h (right): https://codereview.chromium.org/2888673002/diff/100001/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h#newcode29 chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h:29: enum class AMPViewType { On 2017/05/17 at 19:26:43, Ilya ...
3 years, 7 months ago (2017-05-17 22:29:37 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888673002/120001
3 years, 7 months ago (2017-05-18 14:37:29 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 14:42:45 UTC) #34
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/db2e320286b9752ed94f1bc6aa5e...

Powered by Google App Engine
This is Rietveld 408576698